[U-Boot] [linux-sunxi] Re: [PATCH v1 3/9] sunxi: initial sun7i dram setup support

Luke Kenneth Casson Leighton
2014-03-14T17:24:27Z

On Fri, Mar 14, 2014 at 4:28 PM, Henrik Nordstr?m
<henrik@henriknordstrom.net> wrote:
> fre 2014-03-14 klockan 10:17 -0400 skrev Tom Rini:
>
>> And as for the rest of the code, lots of magic numbers to #define
>> what/why (why udelay(2) and 22?)
>
> Unfortunately the only documentation we have on the sun7i DRAM
> controller is Allwinner boot0 + boot1 code, and that code uses.. magic
> numbers & shifts with no explanations.

a terse comment at the top to that effect would likely be worthwhile.

l.