From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 03/10] env_mmc.c: Remove NULL check on tmp_env1/2
Date: Fri, 28 Mar 2014 12:03:35 -0400 [thread overview]
Message-ID: <1396022622-3527-3-git-send-email-trini@ti.com> (raw)
In-Reply-To: <1396022622-3527-1-git-send-email-trini@ti.com>
With 452a272 we moved to allocating these variables on the stack. So
they will never now be NULL so remove these checks.
Signed-off-by: Tom Rini <trini@ti.com>
---
common/env_mmc.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/common/env_mmc.c b/common/env_mmc.c
index d42168b..f47bd77 100644
--- a/common/env_mmc.c
+++ b/common/env_mmc.c
@@ -220,12 +220,6 @@ void env_relocate_spec(void)
mmc = find_mmc_device(dev);
- if (tmp_env1 == NULL || tmp_env2 == NULL) {
- puts("Can't allocate buffers for environment\n");
- ret = 1;
- goto err;
- }
-
if (init_mmc_for_env(mmc)) {
ret = 1;
goto err;
--
1.7.9.5
next prev parent reply other threads:[~2014-03-28 16:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 16:03 [U-Boot] [PATCH v3 01/10] fw_env.c: Switch get_config to use '%ms' in sscanf Tom Rini
2014-03-28 16:03 ` [U-Boot] [PATCH v3 02/10] env_mmc.c: Allow environment to be used within SPL Tom Rini
2014-04-18 13:22 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-03-28 16:03 ` Tom Rini [this message]
2014-04-18 13:22 ` [U-Boot] [U-Boot, v3, 03/10] env_mmc.c: Remove NULL check on tmp_env1/2 Tom Rini
2014-03-28 16:03 ` [U-Boot] [PATCH v3 04/10] mtd: Add a CONFIG_SPL_MTD_SUPPORT for a more full NAND subsystem in SPL Tom Rini
2014-04-18 13:22 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-03-28 16:03 ` [U-Boot] [PATCH v3 05/10] mtd: Build nand_util.o for CONFIG_ENV_IS_IN_NAND " Tom Rini
2014-04-18 13:22 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-03-28 16:03 ` [U-Boot] [PATCH v3 06/10] am335x_evm: Make SPL_OS also check the boot_os variable for falcon mode Tom Rini
2014-04-18 13:22 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-03-28 16:03 ` [U-Boot] [PATCH v3 07/10] README: Add CONFIG_SPL_OS_BOOT to README Tom Rini
2014-04-18 13:22 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-03-28 16:03 ` [U-Boot] [PATCH v3 08/10] README.falcon: Document environment variables for falcon mode Tom Rini
2014-04-18 13:22 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-03-28 16:03 ` [U-Boot] [PATCH v3 09/10] a3m071: Make spl_start_uboot test like getenv_yesno does Tom Rini
2014-04-18 13:22 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-03-28 16:03 ` [U-Boot] [PATCH v3 10/10] spl_mmc/CONFIG_SPL_OS_BOOT: Allow environment to determine what to boot Tom Rini
2014-04-18 13:22 ` [U-Boot] [U-Boot, v3, " Tom Rini
2014-04-18 13:21 ` [U-Boot] [U-Boot, v3, 01/10] fw_env.c: Switch get_config to use '%ms' in sscanf Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396022622-3527-3-git-send-email-trini@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox