From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Marek Vasut <marex@denx.de>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Joe Hershberger <joe.hershberger@ni.com>,
"Tom Rini" <trini@konsulko.com>
Subject: RE: [PATCH] cmd: env: select: Add output for available evironment targets
Date: Thu, 20 Mar 2025 18:05:05 +0000 [thread overview]
Message-ID: <13a5e258ec0d4460ad81f3a301621a5d@dh-electronics.com> (raw)
In-Reply-To: <c990d260-e4cc-41e5-991b-56dc35791f1e@denx.de>
From: Marek Vasut <marex@denx.de>
Sent: Thursday, March 20, 2025 12:56 PM
> On 3/20/25 11:32 AM, Christoph Niedermaier wrote:
>> If "env select" is called without a target parameter the result is
>> "Select Environment on <NULL>: driver not found".
>
> Why is this not the correct output ?
I think it would be better to print an usage message here.
>> Improve the output
>> by showing a list of available evironment targets, where the active
>> target is marked with an asterisk.
>
> If the goal is to add support for listing available env options for 'env
> select' , then better modify cmd/nvedit.c do_env_select() and implement
> some 'env select -l' .
I could do this in v2.
Regards
Christoph
prev parent reply other threads:[~2025-03-20 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 10:32 [PATCH] cmd: env: select: Add output for available evironment targets Christoph Niedermaier
2025-03-20 11:55 ` Marek Vasut
2025-03-20 18:05 ` Christoph Niedermaier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a5e258ec0d4460ad81f3a301621a5d@dh-electronics.com \
--to=cniedermaier@dh-electronics.com \
--cc=joe.hershberger@ni.com \
--cc=marex@denx.de \
--cc=patrick.delaunay@foss.st.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox