From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] AHCI: Increase link timeout to 200ms
Date: Sat, 31 May 2014 17:36:11 +0100 [thread overview]
Message-ID: <1401554175-29599-1-git-send-email-ijc@hellion.org.uk> (raw)
In-Reply-To: <1401554145.15871.100.camel@hastur.hellion.org.uk>
In 73545f75b66d "ahci: wait longer for link" I increased the
timeout to 40ms based on the observed behaviour of a WD disk on a
Cubietruck. Since then Karsten Merker and myself have both
observed timeouts with HGST disks (Karsten on Cubietruck, me on
Cubieboard2). Increasing the timeout to ~175ms fixes this, so go
to 200ms for a bit of headroom.
Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Cc: Karsten Merker <merker@debian.org>
---
drivers/block/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c
index c8f6573..4df8046 100644
--- a/drivers/block/ahci.c
+++ b/drivers/block/ahci.c
@@ -41,7 +41,7 @@ u16 *ataid[AHCI_MAX_PORTS];
#define WAIT_MS_SPINUP 20000
#define WAIT_MS_DATAIO 5000
#define WAIT_MS_FLUSH 5000
-#define WAIT_MS_LINKUP 40
+#define WAIT_MS_LINKUP 200
static inline u32 ahci_port_base(u32 base, u32 port)
{
--
1.9.0
next prev parent reply other threads:[~2014-05-31 16:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 16:35 [U-Boot] [PATCH 0/5] sunxi: GPIO, AHCI and Cubieboard 2 support Ian Campbell
2014-05-31 16:36 ` Ian Campbell [this message]
2014-07-04 14:58 ` [U-Boot] [PATCH 1/5] AHCI: Increase link timeout to 200ms Marek Vasut
2014-07-04 15:26 ` Ian Campbell
2014-07-04 15:44 ` Marek Vasut
2014-07-04 16:16 ` Ian Campbell
2014-05-31 16:36 ` [U-Boot] [PATCH 2/5] board_r: run scsi init() on ARM too Ian Campbell
2014-06-03 3:32 ` Simon Glass
2014-07-04 14:59 ` Marek Vasut
2014-07-04 15:25 ` Ian Campbell
2014-07-04 15:44 ` Marek Vasut
2014-05-31 16:36 ` [U-Boot] [PATCH 3/5] sunxi: add Cubieboard2 support Ian Campbell
2014-05-31 16:36 ` [U-Boot] [PATCH 4/5] sunxi: add gpio driver Ian Campbell
2014-05-31 16:36 ` [U-Boot] [PATCH 5/5] ahci: provide sunxi SATA driver using AHCI platform framework Ian Campbell
2014-06-03 19:49 ` Hans de Goede
2014-06-04 8:37 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401554175-29599-1-git-send-email-ijc@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox