From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] board_r: run scsi init() on ARM too
Date: Sat, 31 May 2014 17:36:12 +0100 [thread overview]
Message-ID: <1401554175-29599-2-git-send-email-ijc@hellion.org.uk> (raw)
In-Reply-To: <1401554145.15871.100.camel@hastur.hellion.org.uk>
This has been disabled for ARM in initr_scsi since that function was
introduced. However it works fine for me on Cubieboard and Cubietruck (with the
upcoming AHCI glue patch).
I also tested on two random ARM platforms which seem to define CONFIG_CMD_SCSI:
- highbank worked fine (on midway hardware)
- omap5_uevm built OK and I confirmed using objdump that things were as
expected (i.e. the default weak scsi_init nop was used).
While there remove the mismatched comment from the #endif (omitting the comment
seems to be the prevailing style in this file) and add a missing return to
initr_doc which I happened to spot while editing.
Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Cc: Simon Glass <sjg@chromium.org>
---
common/board_r.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/common/board_r.c b/common/board_r.c
index 602a239..427ee67 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -588,21 +588,19 @@ static int initr_status_led(void)
#if defined(CONFIG_CMD_SCSI)
static int initr_scsi(void)
{
- /* Not supported properly on ARM yet */
-#ifndef CONFIG_ARM
puts("SCSI: ");
scsi_init();
-#endif
return 0;
}
-#endif /* CONFIG_CMD_NET */
+#endif
#if defined(CONFIG_CMD_DOC)
static int initr_doc(void)
{
puts("DOC: ");
doc_init();
+ return 0
}
#endif
--
1.9.0
next prev parent reply other threads:[~2014-05-31 16:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 16:35 [U-Boot] [PATCH 0/5] sunxi: GPIO, AHCI and Cubieboard 2 support Ian Campbell
2014-05-31 16:36 ` [U-Boot] [PATCH 1/5] AHCI: Increase link timeout to 200ms Ian Campbell
2014-07-04 14:58 ` Marek Vasut
2014-07-04 15:26 ` Ian Campbell
2014-07-04 15:44 ` Marek Vasut
2014-07-04 16:16 ` Ian Campbell
2014-05-31 16:36 ` Ian Campbell [this message]
2014-06-03 3:32 ` [U-Boot] [PATCH 2/5] board_r: run scsi init() on ARM too Simon Glass
2014-07-04 14:59 ` Marek Vasut
2014-07-04 15:25 ` Ian Campbell
2014-07-04 15:44 ` Marek Vasut
2014-05-31 16:36 ` [U-Boot] [PATCH 3/5] sunxi: add Cubieboard2 support Ian Campbell
2014-05-31 16:36 ` [U-Boot] [PATCH 4/5] sunxi: add gpio driver Ian Campbell
2014-05-31 16:36 ` [U-Boot] [PATCH 5/5] ahci: provide sunxi SATA driver using AHCI platform framework Ian Campbell
2014-06-03 19:49 ` Hans de Goede
2014-06-04 8:37 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401554175-29599-2-git-send-email-ijc@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox