From mboxrd@z Thu Jan  1 00:00:00 1970
From: Huan Wang <alison.wang@freescale.com>
Date: Mon, 2 Jun 2014 06:45:47 +0000
Subject: [U-Boot] [PATCH 9/9] arm: ls102xa: Add basic support for
 LS1021AQDS board
In-Reply-To: <CAOMZO5BVA0NkRmaW6wPFAs0TejdqjpT1XODMqLCKmQpx+s1_FQ@mail.gmail.com>
References: <1401434582-18032-1-git-send-email-b18965@freescale.com>
	<1401434582-18032-10-git-send-email-b18965@freescale.com>,
	<CAOMZO5BVA0NkRmaW6wPFAs0TejdqjpT1XODMqLCKmQpx+s1_FQ@mail.gmail.com>
Message-ID: <1401691546939.72918@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi, Fabio,

On Fri, May 30, 2014 at 4:23 AM, Alison Wang <b18965@freescale.com> wrote:

> +#define CONFIG_EXTRA_ENV_SETTINGS????? \
> +?????? "ethaddr=00:e0:0c:bc:e5:60\0"?? \
> +?????? "eth1addr=00:e0:0c:bc:e5:61\0"? \
> +?????? "eth2addr=00:e0:0c:bc:e5:62\0"? \
> +?????? "eth3addr=00:e0:0c:bc:e5:63\0"? \
> +?????? "ipaddr=192.168.1.100\0"??????? \

You should not hardcode any ethaddr/ipaddr.

[Alison Wang] I will remove them in v2. Thanks.

Best Regards,
Alison Wang