From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeroen Hofstee Date: Tue, 03 Jun 2014 20:27:42 +0200 Subject: [U-Boot] [PATCH 2/2] tools: include u-boot version of sha256.h In-Reply-To: References: <1401457528-13709-1-git-send-email-jeroen@myspectrum.nl> <1401457528-13709-3-git-send-email-jeroen@myspectrum.nl> Message-ID: <1401820062.2465.18.camel@yellow> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On di, 2014-06-03 at 08:11 -0600, Simon Glass wrote: > On 30 May 2014 07:45, Jeroen Hofstee wrote: > > When building tools the u-boot specific sha256.h is required, but the > > host version of sha256.h is used when present. This leads to build errors > > on FreeBSD which does have a system sha256.h include. Like libfdt_env.h > > explicitly include u-boot's sha256.h. > > > > cc: Simon Glass > > Signed-off-by: Jeroen Hofstee > > There might be a general approach here, but this is just as reasonable > as the libfdt_env.h inclusion. > > Acked-by: Simon Glass > > (tested with buildman - no build regressions on all boards) Thanks for testing. One of the more generic solutions I considered is to actually move all such headers to include/u-boot. I tried that, but it rapidly becomes a big patch touching files in all archs, which is a bit too big after an rc2 is already out. Tom, since this does fix a build error, can you consider including this in the next release? (and preferably "Makefile: fix clang warnings due to clang support" as well, as it gains nothing but introduces quite some compile noise [but is waiting for feedback from Masahiro]). Regards, Jeroen