public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 03/10] board_r: only assign gd when requested
Date: Tue, 03 Jun 2014 22:52:38 +0200	[thread overview]
Message-ID: <1401828758.2465.64.camel@yellow> (raw)
In-Reply-To: <1401568344-4441-4-git-send-email-jeroen@myspectrum.nl>

Hello Wolfgang / Stefan.

On za, 2014-05-31 at 22:32 +0200, Jeroen Hofstee wrote:
> When CONFIG_SYS_GENERIC_GLOBAL_DATA is not set the arch handles
> the assignment of gd. At least in case of ARM/Aarch64 this means
> board_init_r is alteady called with the new gd. Therefore only
> assign gd if CONFIG_SYS_GENERIC_GLOBAL_DATA is defined.
> ---
>  common/board_r.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/board_r.c b/common/board_r.c
> index 602a239..18bbe26 100644
> --- a/common/board_r.c
> +++ b/common/board_r.c
> @@ -927,7 +927,7 @@ void board_init_r(gd_t *new_gd, ulong dest_addr)
>  	int i;
>  #endif
>  
> -#ifndef CONFIG_X86
> +#ifdef CONFIG_SYS_GENERIC_GLOBAL_DATA
>  	gd = new_gd;
>  #endif
>  

Can any of you confirm this change is fine for powerpc as well?

Regards,
Jeroen

  parent reply	other threads:[~2014-06-03 20:52 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-31 20:32 [U-Boot] [RFC 00/10] clang support for ARM Jeroen Hofstee
2014-05-31 20:32 ` [U-Boot] [RFC 01/10] ARM: crt0.S: clear the global data Jeroen Hofstee
2014-06-03  2:02   ` Simon Glass
2014-06-03 19:41     ` Jeroen Hofstee
2014-06-03 15:36   ` Tim Harvey
2014-07-11 17:55   ` Jeroen Hofstee
2014-05-31 20:32 ` [U-Boot] [RFC 02/10] ARM: omap3/board: add spl specific board_init_f Jeroen Hofstee
2014-05-31 20:32 ` [U-Boot] [RFC 03/10] board_r: only assign gd when requested Jeroen Hofstee
2014-06-03  2:05   ` Simon Glass
2014-06-03 20:52   ` Jeroen Hofstee [this message]
2014-06-04  3:52     ` Stefan Roese
2014-06-04  4:19       ` York Sun
2014-05-31 20:32 ` [U-Boot] [RFC 04/10] ARM: do not set gd in generic board again Jeroen Hofstee
2014-06-03  2:06   ` Simon Glass
2014-05-31 20:32 ` [U-Boot] [RFC 05/10] ARM: SPL: do not set gd again Jeroen Hofstee
2014-06-03  2:07   ` Simon Glass
2014-06-03 15:38   ` Tim Harvey
2014-05-31 20:32 ` [U-Boot] [RFC 06/10] cc-option: make it work with clang Jeroen Hofstee
2014-06-10  8:39   ` Masahiro Yamada
2014-06-10  8:52     ` Albert ARIBAUD
2014-07-05 13:34     ` Jeroen Hofstee
2014-05-31 20:32 ` [U-Boot] [RFC 07/10] ARM: make gd a function a function for clang Jeroen Hofstee
2014-06-03  2:20   ` Simon Glass
2014-06-03 19:44     ` Jeroen Hofstee
2014-06-03 19:58     ` Jeroen Hofstee
2014-06-03 20:00       ` Simon Glass
2014-05-31 20:32 ` [U-Boot] [RFC 08/10] inline: use the gcc inline version instead of the c99 one Jeroen Hofstee
2014-05-31 20:32 ` [U-Boot] [RFC 09/10] eabi_compat: add __aeabi_memcpy __aeabi_memset Jeroen Hofstee
2014-05-31 20:32 ` [U-Boot] [RFC 10/10] README.clang: build command with clang Jeroen Hofstee
2014-07-30 19:54 ` [U-Boot] [PATCH v2 0/8] add clang support for some ARM boards Jeroen Hofstee
2014-07-30 19:54   ` [U-Boot] [PATCH v2 1/8] board_r: ARM[64] do not set gd again Jeroen Hofstee
2014-07-30 19:54   ` [U-Boot] [PATCH v2 2/8] ARM: SPL: " Jeroen Hofstee
2014-07-30 19:54   ` [U-Boot] [PATCH v2 3/8] cc-option: also detect unsupported warnings options Jeroen Hofstee
2014-07-30 19:54   ` [U-Boot] [PATCH v2 4/8] ARM: make gd a function for clang Jeroen Hofstee
2014-07-30 19:54   ` [U-Boot] [PATCH v2 5/8] eabi_compat: add __aeabi_memcpy __aeabi_memset Jeroen Hofstee
2014-07-30 19:54   ` [U-Boot] [PATCH v2 6/8] clang: workaround for generated constants Jeroen Hofstee
2014-07-30 19:54   ` [U-Boot] [PATCH v2 7/8] Makefile: default to cc for host compiler Jeroen Hofstee
2014-07-31 10:01     ` Masahiro Yamada
2014-09-09 14:31       ` Albert ARIBAUD
2014-09-09 17:34         ` Jeroen Hofstee
2014-09-09 19:59           ` Albert ARIBAUD
2014-09-09 21:48             ` Jeroen Hofstee
2014-09-10 10:02             ` Jeroen Hofstee
2014-09-11  5:03           ` Masahiro Yamada
2014-07-30 19:54   ` [U-Boot] [PATCH v2 8/8] README.clang: build command with clang Jeroen Hofstee
2014-09-10 18:08   ` [U-Boot] [PATCH v3 0/8] add clang support for some ARM boards Jeroen Hofstee
2014-09-10 18:08     ` [U-Boot] [PATCH v3 7/8] Makefile: default to cc for host compiler Jeroen Hofstee
2014-09-10 18:08     ` [U-Boot] [PATCH v3 8/8] README.clang: build command with clang Jeroen Hofstee
2014-09-11  8:32     ` [U-Boot] [PATCH v3 0/8] add clang support for some ARM boards Albert ARIBAUD
2014-09-11 11:17       ` Jeroen Hofstee
2014-09-11 13:31         ` Albert ARIBAUD
2014-09-11 20:12           ` Jeroen Hofstee
2014-09-11 15:43         ` Albert ARIBAUD
2014-09-11 19:36           ` Jeroen Hofstee
2014-09-11 15:48     ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401828758.2465.64.camel@yellow \
    --to=jeroen@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox