* [U-Boot] [PATCH] mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC
@ 2014-06-05 22:31 Fabio Estevam
2014-06-06 2:19 ` Marek Vasut
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2014-06-05 22:31 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
mx6 reference manual incorrectly states that the DEVICE_TYPE field of
IOMUXC_GPR12 register should be configured as '0010' for setting the PCI
controller in RC mode. The correct value should be '0100' instead.
This also aligns with the same value used in the mx6 pci kernel driver.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/include/asm/arch-mx6/iomux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-mx6/iomux.h b/arch/arm/include/asm/arch-mx6/iomux.h
index f9ee0d9..6a4a632 100644
--- a/arch/arm/include/asm/arch-mx6/iomux.h
+++ b/arch/arm/include/asm/arch-mx6/iomux.h
@@ -39,7 +39,7 @@
#define IOMUXC_GPR12_LOS_LEVEL_MASK (0x1f << 4)
#define IOMUXC_GPR12_APPS_LTSSM_ENABLE (1 << 10)
#define IOMUXC_GPR12_DEVICE_TYPE_EP (0x0 << 12)
-#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x2 << 12)
+#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x4 << 12)
#define IOMUXC_GPR12_DEVICE_TYPE_MASK (0xf << 12)
/*
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC
2014-06-05 22:31 [U-Boot] [PATCH] mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC Fabio Estevam
@ 2014-06-06 2:19 ` Marek Vasut
2014-06-06 9:45 ` Stefano Babic
2014-06-17 14:29 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2014-06-06 2:19 UTC (permalink / raw)
To: u-boot
On Friday, June 06, 2014 at 12:31:30 AM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> mx6 reference manual incorrectly states that the DEVICE_TYPE field of
> IOMUXC_GPR12 register should be configured as '0010' for setting the PCI
> controller in RC mode. The correct value should be '0100' instead.
>
> This also aligns with the same value used in the mx6 pci kernel driver.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC
2014-06-05 22:31 [U-Boot] [PATCH] mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC Fabio Estevam
2014-06-06 2:19 ` Marek Vasut
@ 2014-06-06 9:45 ` Stefano Babic
2014-06-17 14:29 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2014-06-06 9:45 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 06/06/2014 00:31, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> mx6 reference manual incorrectly states that the DEVICE_TYPE field of
> IOMUXC_GPR12 register should be configured as '0010' for setting the PCI
> controller in RC mode. The correct value should be '0100' instead.
>
> This also aligns with the same value used in the mx6 pci kernel driver.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/include/asm/arch-mx6/iomux.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-mx6/iomux.h b/arch/arm/include/asm/arch-mx6/iomux.h
> index f9ee0d9..6a4a632 100644
> --- a/arch/arm/include/asm/arch-mx6/iomux.h
> +++ b/arch/arm/include/asm/arch-mx6/iomux.h
> @@ -39,7 +39,7 @@
> #define IOMUXC_GPR12_LOS_LEVEL_MASK (0x1f << 4)
> #define IOMUXC_GPR12_APPS_LTSSM_ENABLE (1 << 10)
> #define IOMUXC_GPR12_DEVICE_TYPE_EP (0x0 << 12)
> -#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x2 << 12)
> +#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x4 << 12)
> #define IOMUXC_GPR12_DEVICE_TYPE_MASK (0xf << 12)
>
Acked-by: Stefano Babic <sbabic@denx.de>
I will merge it for the release.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC
2014-06-05 22:31 [U-Boot] [PATCH] mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC Fabio Estevam
2014-06-06 2:19 ` Marek Vasut
2014-06-06 9:45 ` Stefano Babic
@ 2014-06-17 14:29 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2014-06-17 14:29 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 06/06/2014 00:31, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> mx6 reference manual incorrectly states that the DEVICE_TYPE field of
> IOMUXC_GPR12 register should be configured as '0010' for setting the PCI
> controller in RC mode. The correct value should be '0100' instead.
>
> This also aligns with the same value used in the mx6 pci kernel driver.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/include/asm/arch-mx6/iomux.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-mx6/iomux.h b/arch/arm/include/asm/arch-mx6/iomux.h
> index f9ee0d9..6a4a632 100644
> --- a/arch/arm/include/asm/arch-mx6/iomux.h
> +++ b/arch/arm/include/asm/arch-mx6/iomux.h
> @@ -39,7 +39,7 @@
> #define IOMUXC_GPR12_LOS_LEVEL_MASK (0x1f << 4)
> #define IOMUXC_GPR12_APPS_LTSSM_ENABLE (1 << 10)
> #define IOMUXC_GPR12_DEVICE_TYPE_EP (0x0 << 12)
> -#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x2 << 12)
> +#define IOMUXC_GPR12_DEVICE_TYPE_RC (0x4 << 12)
> #define IOMUXC_GPR12_DEVICE_TYPE_MASK (0xf << 12)
>
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-17 14:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-05 22:31 [U-Boot] [PATCH] mx6: Fix definition of IOMUXC_GPR12_DEVICE_TYPE_RC Fabio Estevam
2014-06-06 2:19 ` Marek Vasut
2014-06-06 9:45 ` Stefano Babic
2014-06-17 14:29 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox