From: Ash Charles <ashcharles@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] omap: Don't enable GPMC CS0 with nothing attached
Date: Fri, 6 Jun 2014 11:27:28 -0700 [thread overview]
Message-ID: <1402079248-14490-1-git-send-email-ashcharles@gmail.com> (raw)
In-Reply-To: <CAK8F28=AGUijg5i8A2d7EQLsnwh1bUYmYGPwA6sM5Qe8jk7geA@mail.gmail.com>
If CONFIG_(NAND|NOR|ONENAND) is not defined, no configuration is set
for GPMC on chip select #0---size is 0. In this case, the GPMC
configuration should be reset but not enabled. Enabling causes the
Gumstix DuoVero board to hang when entering Linux.
Signed-off-by: Ash Charles <ashcharles@gmail.com>
---
arch/arm/cpu/armv7/omap-common/mem-common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/cpu/armv7/omap-common/mem-common.c b/arch/arm/cpu/armv7/omap-common/mem-common.c
index 944ef84..f3aa268 100644
--- a/arch/arm/cpu/armv7/omap-common/mem-common.c
+++ b/arch/arm/cpu/armv7/omap-common/mem-common.c
@@ -133,5 +133,6 @@ void gpmc_init(void)
writel(0, &gpmc_cfg->cs[0].config7);
sdelay(1000);
/* enable chip-select specific configurations */
- enable_gpmc_cs_config(gpmc_regs, &gpmc_cfg->cs[0], base, size);
+ if (size != 0)
+ enable_gpmc_cs_config(gpmc_regs, &gpmc_cfg->cs[0], base, size);
}
--
1.8.3.2
next prev parent reply other threads:[~2014-06-06 18:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 16:13 [U-Boot] [PATCH v1 0/3] ARM: omap: add support for GPMC and ELM controllers on OMAP4 and OMAP5 platforms Pekon Gupta
2014-05-08 16:13 ` [U-Boot] [PATCH v1 1/3] ARM: omap4: add platform specific info for GPMC and ELM controllers Pekon Gupta
2014-05-23 23:49 ` [U-Boot] [U-Boot, v1, " Tom Rini
2014-05-08 16:13 ` [U-Boot] [PATCH v1 2/3] ARM: omap5: " Pekon Gupta
2014-05-23 23:49 ` [U-Boot] [U-Boot, v1, " Tom Rini
2014-05-08 16:13 ` [U-Boot] [PATCH v1 3/3] ARM: omap: merge GPMC initialization code for all platform Pekon Gupta
2014-05-23 23:52 ` [U-Boot] [U-Boot, v1, " Tom Rini
2014-05-27 4:47 ` Gupta, Pekon
2014-05-30 21:59 ` Ash Charles
2014-06-06 18:27 ` Ash Charles [this message]
2014-06-19 22:01 ` [U-Boot] omap: Don't enable GPMC CS0 with nothing attached Tom Rini
2014-06-19 22:02 ` Ash Charles
2014-07-08 6:19 ` [U-Boot] [U-Boot, v1, 3/3] ARM: omap: merge GPMC initialization code for all platform Gupta, Pekon
2014-07-08 23:49 ` Ash Charles
2014-07-09 18:16 ` Gupta, Pekon
2014-05-08 18:00 ` [U-Boot] [PATCH v1 0/3] ARM: omap: add support for GPMC and ELM controllers on OMAP4 and OMAP5 platforms Gupta, Pekon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402079248-14490-1-git-send-email-ashcharles@gmail.com \
--to=ashcharles@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox