[U-Boot] [PATCH] ubifs: don't self assign values

Jeroen Hofstee
2014-06-10T21:27:23Z

It seems the code tries to trick the compiler the argument
is actually used. However compilers became too smart too
fool them so easily an now warn. Checking gcc and clang
does not seem to emit a warning. If so it should be decorated
with unused / (void).

cc: Stefan Roese <sr@denx.de>
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
fs/ubifs/recovery.c | 1 -
fs/ubifs/scan.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
index 7444650..b91a8cc 100644
--- a/fs/ubifs/recovery.c
+++ b/fs/ubifs/recovery.c
@@ -392,7 +392,6 @@ static void clean_buf(const struct ubifs_info *c, void **buf, int lnum,
{
int empty_offs, pad_len;

- lnum = lnum;
dbg_rcvry("cleaning corruption at %d:%d", lnum, *offs);

if (c->min_io_size == 1) {
diff --git a/fs/ubifs/scan.c b/fs/ubifs/scan.c
index 0ed8247..633a56f 100644
--- a/fs/ubifs/scan.c
+++ b/fs/ubifs/scan.c
@@ -175,7 +175,6 @@ struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
void ubifs_end_scan(const struct ubifs_info *c, struct ubifs_scan_leb *sleb,
int lnum, int offs)
{
- lnum = lnum;
dbg_scan("stop scanning LEB %d at offset %d", lnum, offs);
ubifs_assert(offs % c->min_io_size == 0);

--
1.8.3.2