public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eli Billauer <eli.billauer@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: sdhci: Fixed timeout for sdhci_send_command()
Date: Thu, 12 Jun 2014 12:41:09 +0300	[thread overview]
Message-ID: <1402566069-8061-2-git-send-email-eli.billauer@gmail.com> (raw)
In-Reply-To: <1402566069-8061-1-git-send-email-eli.billauer@gmail.com>

The current wait loop just reads the status 10000 times, which makes the
actual timeout period platform-dependent. The udelay() call within the loop
makes the new timeout ~100 ms.

Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
---
 drivers/mmc/sdhci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
index 3125d13..80f3a91 100644
--- a/drivers/mmc/sdhci.c
+++ b/drivers/mmc/sdhci.c
@@ -226,6 +226,7 @@ int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd,
 			break;
 		if (--retry == 0)
 			break;
+		udelay(10);
 	} while ((stat & mask) != mask);
 
 	if (retry == 0) {
-- 
1.7.2.3

  reply	other threads:[~2014-06-12  9:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12  9:41 [U-Boot] [PATCH] Timeout for SDHCI commands Eli Billauer
2014-06-12  9:41 ` Eli Billauer [this message]
2014-06-19 16:43   ` [U-Boot] [PATCH] mmc: sdhci: Fixed timeout for sdhci_send_command() Andy Fleming
2014-06-19 16:50     ` Eli Billauer
2014-06-27  9:37   ` Pantelis Antoniou
2014-07-01 18:11     ` Andy Fleming
2014-07-04 21:02     ` Steve Rae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402566069-8061-2-git-send-email-eli.billauer@gmail.com \
    --to=eli.billauer@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox