[U-Boot] [PATCH v3 07/10] net: Rename and cleanup sunxi (Allwinner) emac driver

Stefan Roese
2014-07-26T13:31:56Z

Hi,

On 26.07.2014 15:21, Hans de Goede wrote:
> Hi,
>
> On 07/23/2014 08:12 PM, Siarhei Siamashka wrote:
>> On Mon, 9 Jun 2014 11:36:59 +0200
>> Hans de Goede <hdegoede@redhat.com> wrote:
>>
>>> From: Stefan Roese <sr@denx.de>
>>>
>>> There have been 3 versions of the sunxi_emac support patch during its
>>> development. Somehow version 2 ended up in upstream u-boot where as
>>> the u-boot-sunxi git repo got version 3.
>>>
>>> This bumps the version in upstream u-boot to version 3 of the patch:
>>> - Initialize MII clock earlier so mii access to allow independent use
>>> - Name change from WEMAC to EMAC to match mainline kernel & chip manual
>>> - Cosmetic code cleanup
>>>
>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>> Signed-off-by: Henrik Nordstrom <henrik@henriknordstrom.net>
>>> Signed-off-by: Oliver Schinagl <oliver@schinagl.nl>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>> Acked-by: Ian Campbell <ijc@hellion.org.uk>
>>
>> Shouldn't the cosmetic and functional changes be normally split into
>> separate patches? Indeed, it looks like the move of
>>
>> + /* Set MII clock */
>> + clrsetbits_le32(&regs->mac_mcfg, 0xf << 2, 0xd << 2);
>>
>> is the only functional change in this rather large patch.
>>
>> And could you please elaborate on
>>
>>> - Initialize MII clock earlier so mii access to allow independent use
>>
>> was this causing any user visible problems?
>
> I'm not the author if the patch, so you will need to ask Stefan.

Yes. Sorry, but this was so long ago and I really can't remember the
details here. I suggest to improve the code with follow-up patches if
needed.

Thanks,
Stefan