public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] socfpga: initialize MMC
Date: Thu, 17 Jul 2014 06:00:52 -0500	[thread overview]
Message-ID: <1405594852.2088.8.camel@clsee-VirtualBox.altera.com> (raw)
In-Reply-To: <20140716131330.A93E83804B5@gemini.denx.de>

Hi Wolfgang,

On Wed, 2014-07-16 at 15:13 +0200, ZY - wd wrote:
> Dear Pavel,
> 
> In message <20140716125238.CF3833804B5@gemini.denx.de> I wrote:
> > 
> > > +	add_dwmci(host, host->bus_hz, host->bus_hz);
> > 
> > Is there a free(host) anywhere?


Actually the host will be referred throughout the code execution when
SDMMC access is required. Hence, we can only call the free when exit
which deems not needed then.

Thanks
Chin Liang

> 
> I think there is none, which raises the question why you use malloc()
> in the first place.  Just use a struct on the stack.
> 
> Also, please make sure to check the return code of add_dwmci() for
> errors, and handle these as needed.
> 
> Best regards,
> 
> Wolfgang Denk
> 

  reply	other threads:[~2014-07-17 11:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 12:34 [U-Boot] socfpga: initialize MMC Pavel Machek
2014-07-16 12:52 ` Wolfgang Denk
2014-07-16 13:13   ` Wolfgang Denk
2014-07-17 11:00     ` Chin Liang See [this message]
2014-07-17 12:01       ` Wolfgang Denk
2014-07-19 12:03         ` Pavel Machek
2014-07-21 10:20   ` Pavel Machek
2014-07-21 10:50     ` Wolfgang Denk
2014-07-21 12:05       ` Pavel Machek
2014-07-22  9:33         ` Chin Liang See
2014-09-09 13:16       ` [U-Boot] [PATCH] sort drivers/mmc/Makefile Pavel Machek
2014-09-12  7:25         ` Chin Liang See
2014-11-10 21:29         ` [U-Boot] " Tom Rini
2014-07-21 10:30   ` [U-Boot] [PATCH] socfpga: cleanup socfpga_dw_mmc Pavel Machek
2014-07-21 10:49     ` Chin Liang See
2014-07-21 11:30     ` [U-Boot] [PATCHv2] " Pavel Machek
2014-07-22  4:55       ` Chin Liang See
2014-08-30 15:13       ` [U-Boot] [U-Boot,PATCHv2] " Tom Rini
2014-07-22  3:22 ` [U-Boot] socfpga: initialize MMC Jaehoon Chung
2014-07-22  8:49   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405594852.2088.8.camel@clsee-VirtualBox.altera.com \
    --to=clsee@altera.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox