public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] board_r: run scsi init() on ARM too
Date: Mon, 21 Jul 2014 19:23:18 +0100	[thread overview]
Message-ID: <1405966998.27009.53.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <CAPnjgZ2MzY9yZJokarqTf_V+U1eP8HzNh82kA5LuA0wbP21Siw@mail.gmail.com>

On Fri, 2014-07-18 at 21:12 -0600, Simon Glass wrote:
> Hi Ian,
> 
> On 18 July 2014 13:38, Ian Campbell <ijc@hellion.org.uk> wrote:
> >
> > This has been disabled for ARM in initr_scsi since that function was
> > introduced. However it works fine for me on Cubieboard and Cubietruck (with the
> > upcoming AHCI glue patch).
> >
> > I also tested on two random ARM platforms which seem to define CONFIG_CMD_SCSI:
> >  - highbank worked fine (on midway hardware)
> >  - omap5_uevm built OK and I confirmed using objdump that things were as
> >    expected (i.e. the default weak scsi_init nop was used).
> >
> > While there remove the mismatched comment from the #endif (omitting the comment
> > seems to be the prevailing style in this file) and add a missing return to
> > initr_doc which I happened to spot while editing.
> 
> That's great, but I think the latter should be a separate patch.

I've just sent that out. So here is v3 of this patch. I noticed that you
acked v1 and I failed to pick that up so I've taken the liberty of
adding it here after removing the initr_doc change -- I hope that was
OK.

8<-------------------------

  reply	other threads:[~2014-07-21 18:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 19:38 [U-Boot] [PATCH v3 0/3] sunxi: AHCI support Ian Campbell
2014-07-18 19:38 ` [U-Boot] [PATCH 1/3] AHCI: Increase link timeout to 200ms Ian Campbell
2014-07-19 12:33   ` Hans de Goede
2014-07-19 23:22   ` Wolfgang Denk
2014-07-20  7:06     ` Ian Campbell
2014-07-22 19:24   ` [U-Boot] [U-Boot,1/3] " Tom Rini
2014-07-18 19:38 ` [U-Boot] [PATCH 2/3] board_r: run scsi init() on ARM too Ian Campbell
2014-07-19  3:12   ` Simon Glass
2014-07-21 18:23     ` Ian Campbell [this message]
2014-07-22 19:24       ` [U-Boot] [U-Boot,2/3] " Tom Rini
2014-07-18 19:38 ` [U-Boot] [PATCH 3/3] ahci: provide sunxi SATA driver using AHCI platform framework Ian Campbell
2014-07-19 12:34   ` Hans de Goede
2014-07-22 22:01   ` Tom Rini
2014-07-23  6:59     ` Ian Campbell
2014-07-23  8:14       ` Ian Campbell
2014-07-23 13:04       ` Tom Rini
2014-07-23 13:08         ` [U-Boot] [linux-sunxi] " Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405966998.27009.53.camel@dagon.hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox