[U-Boot] [PATCH 2/3] board_r: run scsi init() on ARM too

Simon Glass
2014-07-19T03:12:36Z

Hi Ian,

On 18 July 2014 13:38, Ian Campbell <ijc@hellion.org.uk> wrote:
>
> This has been disabled for ARM in initr_scsi since that function was
> introduced. However it works fine for me on Cubieboard and Cubietruck (with the
> upcoming AHCI glue patch).
>
> I also tested on two random ARM platforms which seem to define CONFIG_CMD_SCSI:
> - highbank worked fine (on midway hardware)
> - omap5_uevm built OK and I confirmed using objdump that things were as
> expected (i.e. the default weak scsi_init nop was used).
>
> While there remove the mismatched comment from the #endif (omitting the comment
> seems to be the prevailing style in this file) and add a missing return to
> initr_doc which I happened to spot while editing.

That's great, but I think the latter should be a separate patch.

Regards,
Simon