From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/7] sunxi: Kconfig: move common settings into a shared code block
Date: Tue, 05 Aug 2014 08:03:07 +0100 [thread overview]
Message-ID: <1407222187.23472.34.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <CAGb2v648DK5ytpMY=+Qn+Vau1df3comymHDx4hpKKajsvBBXCA@mail.gmail.com>
On Tue, 2014-08-05 at 09:24 +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 5, 2014 at 5:26 AM, Ian Campbell <ijc@hellion.org.uk> wrote:
> > On Fri, 2014-08-01 at 09:46 +0200, Hans de Goede wrote:
> >> SYS_CPU, SYS_BOARD and SYS_SOC are identical for all sunxi boards, move
> >> them to a shared code block.
> >>
> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > This is an improvement so:
> > Acked-by: Ian Campbell <ijc@hellion.org.uk>
> >
> > But eventually we could clean up even more, e.g.
> >
> > config SYS_CONFIG_NAME
> > string
> > default "sun4i" if TARGET_SUN4I
> > default "sun5i" if TARGET_SUN5I
> > etc
> >
> > Possibly even some things should be select'd rather than default'd.
>
> Selected sounds better. :)
The main thing I know about select is that one needs to be very careful
about when it is used, since it can have odd side effects....
Ian.
next prev parent reply other threads:[~2014-08-05 7:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 7:46 [U-Boot] [PATCH 1/7] sunxi-common.h: Remove CONFIG_SYS_BOOT_GET_CMDLINE Hans de Goede
2014-08-01 7:46 ` [U-Boot] [PATCH 2/7] sunxi-common.h: Remove dead #ifdef CONFIG_CMD_NET code block Hans de Goede
2014-08-04 21:19 ` Ian Campbell
2014-08-01 7:46 ` [U-Boot] [PATCH 3/7] sunxi-common.h: Don't undefine CONFIG_CMD_NFS Hans de Goede
2014-08-04 21:19 ` Ian Campbell
2014-08-01 7:46 ` [U-Boot] [PATCH 4/7] sunxi-common.h: Don't undef CONFIG_CMD_NET only to redefine it again later Hans de Goede
2014-08-04 21:20 ` Ian Campbell
2014-08-01 7:46 ` [U-Boot] [PATCH 5/7] sunxi-common.h: Use new generic $bootcmd Hans de Goede
2014-08-01 7:48 ` Hans de Goede
2014-08-01 18:54 ` Stephen Warren
2014-08-04 18:35 ` Hans de Goede
2014-08-04 21:21 ` Ian Campbell
2014-08-01 7:46 ` [U-Boot] [PATCH 6/7] sunxi: Kconfig: move common settings into a shared code block Hans de Goede
2014-08-04 21:26 ` Ian Campbell
2014-08-05 1:24 ` Chen-Yu Tsai
2014-08-05 7:03 ` Ian Campbell [this message]
2014-08-01 7:46 ` [U-Boot] [PATCH 7/7] sunxi: Add environment settings to make extlinux.conf booting work Hans de Goede
2014-08-01 18:57 ` Stephen Warren
2014-08-01 20:05 ` Dennis Gilmore
2014-08-01 20:22 ` Stephen Warren
2014-08-01 20:30 ` Dennis Gilmore
2014-08-01 20:43 ` Tom Rini
2014-08-01 21:43 ` Stephen Warren
2014-08-02 1:53 ` Tom Rini
2014-08-04 17:31 ` Stephen Warren
2014-08-04 20:12 ` Tom Rini
2014-08-04 21:29 ` Ian Campbell
2014-08-05 8:20 ` Hans de Goede
2014-08-04 21:27 ` Ian Campbell
2014-08-05 8:21 ` Hans de Goede
2014-08-30 21:57 ` Ian Campbell
2014-08-31 10:07 ` Hans de Goede
2014-08-04 21:17 ` [U-Boot] [PATCH 1/7] sunxi-common.h: Remove CONFIG_SYS_BOOT_GET_CMDLINE Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407222187.23472.34.camel@dagon.hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox