public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Roger Meier <roger@bufferoverflow.ch>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools: genboardscfg.py, use default terminal size if undetectable
Date: Thu,  7 Aug 2014 12:46:53 +0200	[thread overview]
Message-ID: <1407408413-19313-1-git-send-email-roger@bufferoverflow.ch> (raw)

The existing terminalsize detection raised an exception on build
server. Removes the exception and return a default value.

Signed-off-by: Roger Meier <roger@bufferoverflow.ch>
CC: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
 tools/genboardscfg.py |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py
index 734d90b..892c033 100755
--- a/tools/genboardscfg.py
+++ b/tools/genboardscfg.py
@@ -58,11 +58,9 @@ def get_terminal_columns():
         try:
             ret = fcntl.ioctl(sys.stdout.fileno(), termios.TIOCGWINSZ, arg)
         except IOError as exception:
-            if exception.errno != errno.ENOTTY:
-                raise
             # If 'Inappropriate ioctl for device' error occurs,
-            # stdout is probably redirected. Return 0.
-            return 0
+            # stdout is probably redirected. Return default size.
+            return (25, 80)
         return struct.unpack('hhhh', ret)[1]
 
 def get_devnull():
@@ -408,7 +406,7 @@ def __gen_boards_cfg(jobs):
       jobs: The number of jobs to run simultaneously
 
     Note:
-      The incomplete boards.cfg is left over when an error (including 
+      The incomplete boards.cfg is left over when an error (including
       the termination by the keyboard interrupt) occurs on the halfway.
     """
     check_top_directory()
-- 
1.7.10.4

             reply	other threads:[~2014-08-07 10:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07 10:46 Roger Meier [this message]
2014-08-07 11:37 ` [U-Boot] [PATCH] tools: genboardscfg.py, use default terminal size if undetectable Tom Rini
2014-08-07 12:15   ` Roger Meier
2014-08-07 12:47     ` Masahiro Yamada
2014-08-07 14:19       ` [U-Boot] [PATCH v3] tools: genboardscfg.py, no exception if columns undetectable Roger Meier
2014-08-09  0:37         ` Masahiro YAMADA
2014-08-17 16:07           ` Roger Meier
2014-08-23 12:42         ` [U-Boot] [U-Boot, " Tom Rini
2014-08-07 12:47 ` [U-Boot] [PATCH] tools: genboardscfg.py, use default terminal size if undetectable Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407408413-19313-1-git-send-email-roger@bufferoverflow.ch \
    --to=roger@bufferoverflow.ch \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox