From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/4] mtd: nand: add Freescale NFC driver
Date: Thu, 14 Aug 2014 14:49:52 -0500 [thread overview]
Message-ID: <1408045792.7427.217.camel@snotra.buserror.net> (raw)
In-Reply-To: <70dc426d4c612b10f760337ffdb5f79aff173a8f.1408031213.git.stefan@agner.ch>
On Thu, 2014-08-14 at 18:30 +0200, Stefan Agner wrote:
> +#define DRV_NAME "fsl_nfc"
DRV_NAME doesn't match filename (neither does the patch title), and it
doesn't seem all that useful anyway -- the one place that uses it would
be better off using __func__.
> +static int vf610_nfc_nand_init(int devnum, u8 *addr)
Why u8? Either use void or u32. Also should have __iomem.
...OK, I see you copied that from the examples I pointed out. I have no
idea why those use u8 either. :-(
> + chip->IO_ADDR_R = chip->IO_ADDR_W = nfc->regs = (void __iomem *)addr;
Don't set IO_ADDR_R/IO_ADDR_W if they're not going to be used.
-Scott
next prev parent reply other threads:[~2014-08-14 19:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 16:30 [U-Boot] [PATCH v2 0/4] arm: vf610: add NAND flash support Stefan Agner
2014-08-14 16:30 ` [U-Boot] [PATCH v2 1/4] arm: vf610: add NFC pin mux Stefan Agner
2014-08-14 16:30 ` [U-Boot] [PATCH v2 2/4] arm: vf610: add NFC clock support Stefan Agner
2014-08-14 16:30 ` [U-Boot] [PATCH v2 3/4] mtd: nand: add Freescale NFC driver Stefan Agner
2014-08-14 18:34 ` Bill Pringlemeir
2014-08-14 19:49 ` Scott Wood [this message]
2014-08-14 21:12 ` Bill Pringlemeir
2014-08-18 9:41 ` Stefan Agner
2014-08-18 16:38 ` Bill Pringlemeir
2014-08-19 17:00 ` Stefan Agner
2014-08-21 21:15 ` [U-Boot] [PATCH v3 3/4] mtd: nand: add Freescale vf610_nfc driver Bill Pringlemeir
2014-09-11 9:37 ` Stefano Babic
2014-08-14 16:30 ` [U-Boot] [PATCH v2 4/4] arm: vf610: add NAND support for vf610twr Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408045792.7427.217.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox