[U-Boot] [PATCH 19/23] ARM: tegra: Enable PCIe on Beaver

Thierry Reding
2014-08-22T12:33:57Z

On Wed, Aug 20, 2014 at 12:43:58PM -0600, Stephen Warren wrote:
> On 08/18/2014 01:16 AM, Thierry Reding wrote:
> >From: Thierry Reding <treding@nvidia.com>
> >
> >The Beaver has an ethernet NIC connected to the PCIe bus. Enable the
> >PCIe controller and the network device driver so that the device can
> >boot over the network.
> >
> >In addition the board has a mini-PCIe expansion slot.
>
> >diff --git a/arch/arm/dts/tegra30-beaver.dts b/arch/arm/dts/tegra30-beaver.dts
>
> >+ pcie-controller {
> >+ status = "okay";
> >+ pex-clk-supply = <&sys_3v3_pexs_reg>;
> >+ vdd-supply = <&ldo1_reg>;
> >+ avdd-supply = <&ldo2_reg>;
>
> Just like TrimSlice, there are more regulator references in the kernel DT.
>
> The same comment applies to the next patch (i.e. the Cardhu DT patch)

Done. I also added the unit address to the PCIe controller node name for
consistency.

> >+ regulators {
> ...
> >+ vdd_5v_in_reg: regulator at 0 {
> ...
> >+ sys_3v3_reg: regulator at 6 {
> ...
> >+ sys_3v3_pexs_reg: regulator at 7 {
>
> This only adds 3 of the regulators that are in the kernel DT. Can we just
> add the whole regulators node so the two are consistent?

Done.

> >diff --git a/board/nvidia/cardhu/cardhu.c b/board/nvidia/cardhu/cardhu.c
>
> The commit description says Beaver...
>
> I guess this should be part of the next patch, and the two swapped?

Done.

Thanks,
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140822/2d255c26/attachment.pgp>