public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: tegra: initial support for apalis t30
Date: Wed, 20 Aug 2014 09:35:37 +0200	[thread overview]
Message-ID: <1408520137.22441.3.camel@localhost.localdomain> (raw)
In-Reply-To: <53F3C4B8.40805@wwwdotorg.org>

On Tue, 2014-08-19 at 15:42 -0600, Stephen Warren wrote:
> At a quick glance this looks OK,
> Acked-by: Stephen Warren <swarren@nvidia.com>

Thanks mate. Glad to get ready for more PCIe action now.

> One very minor nit:
> 
> > diff --git a/arch/arm/dts/tegra30-apalis.dts b/arch/arm/dts/tegra30-apalis.dts
> 
> > +	/* GEN1_I2C: I2C1_SDA/SCL on MXM3 pin 209/211 (e.g. RTC on carrier
> > +	   board) */
> 
> That comment style is odd. It should be:
> 
> /*
>   * Text here
>   * More here
>   */

You're absolutely right. I believe you and/or Stefan already reminded me
about that one at least once during my kernel submission which I fixed
in that respect. Don't know how it sneaked itself back into this one now
again. Please forgive. I owe some beer.

      reply	other threads:[~2014-08-20  7:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <74725faaf1af8f3d1791693634e69f5ba1eb9f38.1408403674.git.marcel@ziswiler.com>
2014-08-18 23:22 ` [U-Boot] [PATCH] arm: tegra: initial support for apalis t30 Marcel Ziswiler
2014-08-19 21:42   ` Stephen Warren
2014-08-20  7:35     ` Marcel Ziswiler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408520137.22441.3.camel@localhost.localdomain \
    --to=marcel@ziswiler.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox