From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Ziswiler Date: Wed, 20 Aug 2014 09:35:37 +0200 Subject: [U-Boot] [PATCH] arm: tegra: initial support for apalis t30 In-Reply-To: <53F3C4B8.40805@wwwdotorg.org> References: <74725faaf1af8f3d1791693634e69f5ba1eb9f38.1408403674.git.marcel@ziswiler.com> <53F3C4B8.40805@wwwdotorg.org> Message-ID: <1408520137.22441.3.camel@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 2014-08-19 at 15:42 -0600, Stephen Warren wrote: > At a quick glance this looks OK, > Acked-by: Stephen Warren Thanks mate. Glad to get ready for more PCIe action now. > One very minor nit: > > > diff --git a/arch/arm/dts/tegra30-apalis.dts b/arch/arm/dts/tegra30-apalis.dts > > > + /* GEN1_I2C: I2C1_SDA/SCL on MXM3 pin 209/211 (e.g. RTC on carrier > > + board) */ > > That comment style is odd. It should be: > > /* > * Text here > * More here > */ You're absolutely right. I believe you and/or Stefan already reminded me about that one at least once during my kernel submission which I fixed in that respect. Don't know how it sneaked itself back into this one now again. Please forgive. I owe some beer.