public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Roger Meier <roger@bufferoverflow.ch>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] Makefile: remove generated boards.cfg within make distclean
Date: Wed, 20 Aug 2014 22:10:29 +0200	[thread overview]
Message-ID: <1408565429-13133-1-git-send-email-roger@bufferoverflow.ch> (raw)
In-Reply-To: <1408490030-19643-1-git-send-email-roger@bufferoverflow.ch>

Signed-off-by: Roger Meier <roger@bufferoverflow.ch>
Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Tom Rini <trini@ti.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Simon Glass <sjg@chromium.org>

---
Changes for v2:
   - remove boards.cfg within make distclean instead of mrproper
   - use mrproper instead of distclean within MAKEALL
Changes for v3:
   - use @rm instead of rm as suggested by Masahiro Yamada
Changes for v4:
   - remove the backslash after "xargs rm -f"
   - use mrproper instead of distclean within buildman
---
 MAKEALL                         |    2 +-
 Makefile                        |    1 +
 tools/buildman/builder.py       |    2 +-
 tools/buildman/builderthread.py |    6 +++---
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/MAKEALL b/MAKEALL
index 929fe88..392ea8d 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -658,7 +658,7 @@ build_target() {
 		MAKE="${MAKE} O=${output_dir}"
 	fi
 
-	${MAKE} distclean >/dev/null
+	${MAKE} mrproper >/dev/null
 
 	echo "Building ${target} board..."
 	${MAKE} -s ${target}_defconfig >/dev/null
diff --git a/Makefile b/Makefile
index b5d5e01..c3d7afd 100644
--- a/Makefile
+++ b/Makefile
@@ -1287,6 +1287,7 @@ distclean: mrproper
 		-o -name '.*.rej' -o -name '*%' -o -name 'core' \
 		-o -name '*.pyc' \) \
 		-type f -print | xargs rm -f
+	@rm -f boards.cfg
 
 backup:
 	F=`basename $(srctree)` ; cd .. ; \
diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py
index d5b8454..a555bd8 100644
--- a/tools/buildman/builder.py
+++ b/tools/buildman/builder.py
@@ -308,7 +308,7 @@ class Builder:
         Args:
             commit: Commit object that is being built
             brd: Board object that is being built
-            stage: Stage that we are at (distclean, config, build)
+            stage: Stage that we are at (mrproper, config, build)
             cwd: Directory where make should be run
             args: Arguments to pass to make
             kwargs: Arguments to pass to command.RunPipe()
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index 32297e2..8214662 100644
--- a/tools/buildman/builderthread.py
+++ b/tools/buildman/builderthread.py
@@ -91,7 +91,7 @@ class BuilderThread(threading.Thread):
             commit: Commit object that is being built
             brd: Board object that is being built
             stage: Stage of the build. Valid stages are:
-                        distclean - can be called to clean source
+                        mrproper - can be called to clean source
                         config - called to configure for a board
                         build - the main make invocation - it does the build
             args: A list of arguments to pass to 'make'
@@ -200,8 +200,8 @@ class BuilderThread(threading.Thread):
 
                 # If we need to reconfigure, do that now
                 if do_config:
-                    result = self.Make(commit, brd, 'distclean', cwd,
-                            'distclean', *args, env=env)
+                    result = self.Make(commit, brd, 'mrproper', cwd,
+                            'mrproper', *args, env=env)
                     result = self.Make(commit, brd, 'config', cwd,
                             *(args + config_args), env=env)
                     config_out = result.combined
-- 
1.7.10.4

  parent reply	other threads:[~2014-08-20 20:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07 10:52 [U-Boot] [PATCH] Makefile: remove generated boards.cfg within make mrproper Roger Meier
2014-08-07 12:40 ` Masahiro Yamada
2014-08-07 14:53   ` Roger Meier
2014-08-08 12:48     ` Tom Rini
2014-08-10 12:37       ` [U-Boot] [PATCH v2] Makefile: remove generated boards.cfg within make distclean Roger Meier
2014-08-11 22:52         ` Masahiro YAMADA
2014-08-12 14:37           ` Simon Glass
2014-08-18  4:23         ` Masahiro Yamada
2014-08-19 23:13         ` [U-Boot] [PATCH v3] " Roger Meier
2014-08-20  1:06           ` Masahiro Yamada
2014-08-20 20:10           ` Roger Meier [this message]
2014-08-22  6:30             ` [U-Boot] [PATCH v4] " Masahiro Yamada
2014-08-23 12:43             ` [U-Boot] [U-Boot, " Tom Rini
2014-08-09  0:19     ` [U-Boot] [PATCH] Makefile: remove generated boards.cfg within make mrproper Masahiro YAMADA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408565429-13133-1-git-send-email-roger@bufferoverflow.ch \
    --to=roger@bufferoverflow.ch \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox