From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Date: Mon, 25 Aug 2014 12:39:44 +0900 Subject: [U-Boot] [PATCH v3 3/7] tools/genboardscfg.py: be tolerant of insane Kconfig In-Reply-To: <1408937988-19923-1-git-send-email-yamada.m@jp.panasonic.com> References: <1408937988-19923-1-git-send-email-yamada.m@jp.panasonic.com> Message-ID: <1408937988-19923-4-git-send-email-yamada.m@jp.panasonic.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de The tools/genboardscfg.py expects all the Kconfig and defconfig are written correctly. Imagine someone accidentally has broken a board. Error-out just for one broken board is annoying for the other developers. Let the tool skip insane boards and continue processing. Signed-off-by: Masahiro Yamada Acked-by: Simon Glass --- Changes in v3: None Changes in v2: None tools/genboardscfg.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/genboardscfg.py b/tools/genboardscfg.py index 2ff2dbd..722b316 100755 --- a/tools/genboardscfg.py +++ b/tools/genboardscfg.py @@ -215,7 +215,10 @@ class DotConfigParser: # sanity check of '.config' file for field in self.must_fields: if not field in fields: - sys.exit('Error: %s is not defined in %s' % (field, defconfig)) + print >> sys.stderr, ( + "WARNING: '%s' is not defined in '%s'. Skip." % + (field, defconfig)) + return # fix-up for aarch64 if fields['arch'] == 'arm' and 'cpu' in fields: @@ -307,7 +310,11 @@ class Slot: return True if self.ps.poll() == None: return False - self.parser.parse(self.defconfig) + if self.ps.poll() == 0: + self.parser.parse(self.defconfig) + else: + print >> sys.stderr, ("WARNING: failed to process '%s'. skip." % + self.defconfig) self.occupied = False return True -- 1.9.1