From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] sunxi: Correct typo CONFIG_FTDFILE => CONFIG_FDTFILE
Date: Sun, 31 Aug 2014 15:34:30 +0100 [thread overview]
Message-ID: <1409495670.7613.4.camel@hellion.org.uk> (raw)
In-Reply-To: <CAMhH57T93kDSq2fBBRi8XzUf-eMvEZ2vVweEwUZrETY9gBQ6RQ@mail.gmail.com>
On Sun, 2014-08-31 at 22:18 +0900, Masahiro YAMADA wrote:
> Hi Ian,
>
>
> 2014-08-31 21:13 GMT+09:00 Ian Campbell <ijc@hellion.org.uk>:
> > Patch is the result of:
> > sed -i -e 's/FTDFILE/FDTFILE/g' board/sunxi/Kconfig configs/* include/configs/sunxi-common.h
> > sed -i -e 's/ftdfile/fdtfile/g' board/sunxi/Kconfig
> >
> > Spotted-by: Vagrant Cascadian <vagrant@debian.org>
> > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
>
> I have never seen 'Spotted-by' in U-Boot.
> (I can see it in Linux, but really rare.)
>
> In U-boot (and Linux), Reported-by or Suggested-by is more common:
>
> $ git log --grep='Reported-by:' | wc
> 2812 12393 108877
> $ git log --grep='Suggested-by:' | wc
> 434 1848 16214
> $ git log --grep='Spotted-by:' | wc
> 0 0 0
>
> In my opition, we should use the tags documented in the following page:
> https://www.kernel.org/doc/Documentation/SubmittingPatches
I'm not planning to respin for such a trivial thing (it's purely
informational) but if the committer (which might be me) wants to change
it then that's fine by me.
Ian
next prev parent reply other threads:[~2014-08-31 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 12:13 [U-Boot] [PATCH v2] sunxi: Correct typo CONFIG_FTDFILE => CONFIG_FDTFILE Ian Campbell
2014-08-31 13:18 ` Masahiro YAMADA
2014-08-31 14:34 ` Ian Campbell [this message]
2014-09-01 8:30 ` Hans de Goede
2014-09-02 15:01 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409495670.7613.4.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox