From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Sun, 31 Aug 2014 15:34:30 +0100 Subject: [U-Boot] [PATCH v2] sunxi: Correct typo CONFIG_FTDFILE => CONFIG_FDTFILE In-Reply-To: References: <1409487223-8434-1-git-send-email-ijc@hellion.org.uk> Message-ID: <1409495670.7613.4.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 2014-08-31 at 22:18 +0900, Masahiro YAMADA wrote: > Hi Ian, > > > 2014-08-31 21:13 GMT+09:00 Ian Campbell : > > Patch is the result of: > > sed -i -e 's/FTDFILE/FDTFILE/g' board/sunxi/Kconfig configs/* include/configs/sunxi-common.h > > sed -i -e 's/ftdfile/fdtfile/g' board/sunxi/Kconfig > > > > Spotted-by: Vagrant Cascadian > > Signed-off-by: Ian Campbell > > I have never seen 'Spotted-by' in U-Boot. > (I can see it in Linux, but really rare.) > > In U-boot (and Linux), Reported-by or Suggested-by is more common: > > $ git log --grep='Reported-by:' | wc > 2812 12393 108877 > $ git log --grep='Suggested-by:' | wc > 434 1848 16214 > $ git log --grep='Spotted-by:' | wc > 0 0 0 > > In my opition, we should use the tags documented in the following page: > https://www.kernel.org/doc/Documentation/SubmittingPatches I'm not planning to respin for such a trivial thing (it's purely informational) but if the committer (which might be me) wants to change it then that's fine by me. Ian