From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chin Liang See Date: Fri, 12 Sep 2014 01:17:03 -0500 Subject: [U-Boot] [PATCH] watchdog disable for socfpga In-Reply-To: <20140909130948.GA25925@amd> References: <201409091420.23913.marex@denx.de> <20140909123001.GA24029@amd> <201409091431.46729.marex@denx.de> <20140909130948.GA25925@amd> Message-ID: <1410502623.1904.4.camel@clsee-VirtualBox.altera.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Pavel, On Tue, 2014-09-09 at 15:09 +0200, ZY - pavel wrote: > On Tue 2014-09-09 14:31:46, Marek Vasut wrote: > > On Tuesday, September 09, 2014 at 02:30:01 PM, Pavel Machek wrote: > > > On Tue 2014-09-09 14:20:23, Marek Vasut wrote: > > > > On Tuesday, September 09, 2014 at 02:03:28 PM, Pavel Machek wrote: > > > > > This adds watchdog disable. It is neccessary for running Linux kernel. > > > > > > > > Why do we not enable WDT in Linux instead ? Also, I recall there was a > > > > call to explicitly enable the L4 watchdog, so why do we not get rid of > > > > that instead ? > > > > > > Booting linux kernel without watchdog support should be valid > > > operation. > > > > If you watchdog is enabled, then not so much. Also, why can we not just disable > > the WDT in U-Boot instead using a config option ? > > It seems that watchdog is enabled by default (by hardware or SPL), so > yes, watchdog disable operation (and this patch) in u-boot is a good > idea. If refer to http://rocketboards.org/gitweb/?p=u-boot-socfpga.git;a=blob_plain;f=arch/arm/cpu/armv7/socfpga/s_init.c;hb=fe010493a1754e761f77ba19243ba93a9d038443, its current disable during U-Boot initialization, s_init. Thanks Chin Liang > > Pavel