From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chin Liang See <clsee@altera.com>
Date: Fri, 12 Sep 2014 02:21:25 -0500
Subject: [U-Boot] [PATCH] dw_mmc: cleanups
In-Reply-To: <54110396.6030609@samsung.com>
References: <20140905104948.GA2511@amd> <54110396.6030609@samsung.com>
Message-ID: <1410506485.1904.19.camel@clsee-VirtualBox.altera.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On Thu, 2014-09-11 at 11:06 +0900, Jaehoon Chung wrote:
> Hi, Pavel.
> 
> It looks good to me. 
> If you're ok, can i suggest one thing?
> 
> On 09/05/2014 07:49 PM, Pavel Machek wrote:
> > 
> > dw_mmc driver was responding to errors with debug(). Change that to
> > prinf so that any errors are immediately obvious. Also adjust english
> > in comments.
> > 
> > Signed-off-by: Pavel Machek <pavel@denx.de>
> > 
> > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> > index 0df30bc..4c16e7f 100644
> > --- a/drivers/mmc/dw_mmc.c
> > +++ b/drivers/mmc/dw_mmc.c
> > @@ -260,7 +262,7 @@ static int dwmci_setup_bus(struct dwmci_host *host, u32 freq)
> >  	do {
> >  		status = dwmci_readl(host, DWMCI_CMD);
> >  		if (timeout-- < 0) {
> > -			printf("TIMEOUT error!!\n");
> > +			printf("dwmci_setup_bus: timeout!\n");
> >  			return -ETIMEDOUT;
> >  		}
> >  	} while (status & DWMCI_CMD_START);
> > @@ -275,7 +277,7 @@ static int dwmci_setup_bus(struct dwmci_host *host, u32 freq)
> >  	do {
> >  		status = dwmci_readl(host, DWMCI_CMD);
> >  		if (timeout-- < 0) {
> > -			printf("TIMEOUT error!!\n");
> > +			printf("dwmci_setup_bus: timeout!\n");
> According to your the main purpose, this patch is goal that noticed where/what error is occurred.
> Then i think good that add the "__LINE__".
> Because there are same message like "dwmci_setup_bus: tiemout!\n" at some place.
> 
> Then i think we don't need to discuss about this patch with Marek. :)
> 

This patch looks good except need to distinguish the error location as
pointed by Jaehoon.

Thanks
Chin Liang


> Best Regards,
> Jaehoon Chung
>