From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cleanup drivers/net/phy/micrel.c
Date: Mon, 15 Sep 2014 01:44:46 -0500 [thread overview]
Message-ID: <1410763486.2763.0.camel@clsee-VirtualBox.altera.com> (raw)
In-Reply-To: <20140909122651.GD20662@amd>
On Tue, 2014-09-09 at 14:26 +0200, ZY - pavel wrote:
> Old saying says that more than three exclamation marks in a row are
> sign of mental disease. Cleanup micrel.c.
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 5d7e3be..06a31b0 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -25,8 +25,7 @@ static struct phy_driver KSZ804_driver = {
> #ifndef CONFIG_PHY_MICREL_KSZ9021
> /*
> * I can't believe Micrel used the exact same part number
> - * for the KSZ9021
> - * Shame Micrel, Shame!!!!!
> + * for the KSZ9021. Shame Micrel, Shame!
> */
> static struct phy_driver KS8721_driver = {
> .name = "Micrel KS8721BL",
> @@ -40,7 +39,7 @@ static struct phy_driver KS8721_driver = {
> #endif
>
>
> -/**
> +/*
> * KSZ9021 - KSZ9031 common
> */
>
> @@ -69,8 +68,8 @@ static int ksz90xx_startup(struct phy_device *phydev)
> phydev->speed = SPEED_10;
> return 0;
> }
> -#ifdef CONFIG_PHY_MICREL_KSZ9021
>
> +#ifdef CONFIG_PHY_MICREL_KSZ9021
> /*
> * KSZ9021
> */
>
>
Acked-by: Chin Liang See <clsee@altera.com>
next prev parent reply other threads:[~2014-09-15 6:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 0:22 [U-Boot] Mainline u-boot SPL for socfpga Charles Manning
2014-05-08 10:24 ` Chin Liang See
2014-05-11 22:19 ` Charles Manning
2014-05-14 16:42 ` Pavel Machek
2014-05-14 19:01 ` Charles Manning
2014-05-16 8:42 ` Chin Liang See
2014-05-27 12:40 ` Pavel Machek
2014-05-27 12:50 ` [U-Boot] [PATCH] generic board " Pavel Machek
2014-06-02 5:48 ` Chin Liang See
2014-09-09 8:45 ` Albert ARIBAUD
2014-09-09 11:25 ` [U-Boot] [PATCHv2] " Pavel Machek
2014-09-09 12:03 ` [U-Boot] [PATCH] watchdog disable " Pavel Machek
2014-09-09 12:05 ` [U-Boot] [PATCH] base addresses for more subsystems Pavel Machek
2014-09-09 12:26 ` [U-Boot] [PATCH] cleanup drivers/net/phy/micrel.c Pavel Machek
2014-09-15 6:44 ` Chin Liang See [this message]
2014-09-12 6:25 ` [U-Boot] [PATCH] base addresses for more subsystems Chin Liang See
2014-09-09 12:08 ` [U-Boot] [PATCH] fix compilation of socfpga_dw_mmc Pavel Machek
2014-09-09 12:16 ` Marek Vasut
2014-09-09 12:20 ` [U-Boot] [PATCH] watchdog disable for socfpga Marek Vasut
2014-09-09 12:30 ` Pavel Machek
2014-09-09 12:31 ` Marek Vasut
2014-09-09 13:09 ` Pavel Machek
2014-09-09 13:46 ` Marek Vasut
2014-09-12 6:17 ` Chin Liang See
2014-09-12 6:10 ` Chin Liang See
2014-09-12 6:17 ` Marek Vasut
2014-09-12 5:53 ` [U-Boot] [PATCHv2] generic board " Chin Liang See
2014-06-02 5:54 ` [U-Boot] Mainline u-boot SPL " Chin Liang See
2014-06-03 8:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410763486.2763.0.camel@clsee-VirtualBox.altera.com \
--to=clsee@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox