From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Sun, 21 Sep 2014 19:35:45 +0100 Subject: [U-Boot] [PATCH 4/7] ARM: sun6i: Add clock support In-Reply-To: <1410182892-18647-5-git-send-email-wens@csie.org> References: <1410182892-18647-1-git-send-email-wens@csie.org> <1410182892-18647-5-git-send-email-wens@csie.org> Message-ID: <1411324545.27559.12.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote: > +#ifdef CONFIG_SPL_BUILD Since there is no SPL support this is dead code right now, correct? I'm wondering whether we should leave it out of mainline until the SPL stuff is done, so SPL will be upstreamed all at once. What do others think? > + /* Set PLL ldo voltage without this PLL6 does not work properly */ Is "this" here the doing it 3 times bit? If that's deliberate then please say so explicitly. e.g. "Set PLL LDO voltage 3 times, without ... etc"), if it's not deliberate then please fix ;-) I'm assuming this is one of those "no docs, allwinner code did it but nobody knows why it works" scenarios. Of course if the reason is known/doc'd then please add a reference. > + writel(PRCM_PLL_CTRL_LDO_DIGITAL_EN | PRCM_PLL_CTRL_LDO_ANALOG_EN | > + PRCM_PLL_CTRL_EXT_OSC_EN | PRCM_PLL_CTRL_LDO_OUT_L(1140) | > + PRCM_PLL_CTRL_LDO_KEY, &prcm->pll_ctrl1); > + writel(PRCM_PLL_CTRL_LDO_DIGITAL_EN | PRCM_PLL_CTRL_LDO_ANALOG_EN | > + PRCM_PLL_CTRL_EXT_OSC_EN | PRCM_PLL_CTRL_LDO_OUT_L(1140) | > + PRCM_PLL_CTRL_LDO_KEY, &prcm->pll_ctrl1); > + writel(PRCM_PLL_CTRL_LDO_DIGITAL_EN | PRCM_PLL_CTRL_LDO_ANALOG_EN | > + PRCM_PLL_CTRL_EXT_OSC_EN | PRCM_PLL_CTRL_LDO_OUT_L(1140), > + &prcm->pll_ctrl1); [...] Ian.