[U-Boot] [PATCH v2 10/10] ARM: sun6i: Add Colombus board defconfig

Ian Campbell
2014-09-28T15:43:30Z

On Sun, 2014-09-28 at 23:37 +0800, Chen-Yu Tsai wrote:
> On Sun, Sep 28, 2014 at 11:33 PM, Ian Campbell <ijc@hellion.org.uk> wrote:
> > On Thu, 2014-09-25 at 20:09 +0100, Ian Campbell wrote:
> >> On Wed, 2014-09-24 at 16:01 +0800, Chen-Yu Tsai wrote:
> >> > The Colombus board is an A31 evaluation board from WITS Technology.
> >> >
> >> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >>
> >> > ---
> >> > configs/Colombus_defconfig | 4 ++++
> >> > 1 file changed, 4 insertions(+)
> >> > create mode 100644 configs/Colombus_defconfig
> >> >
> >> > diff --git a/configs/Colombus_defconfig b/configs/Colombus_defconfig
> >> > new file mode 100644
> >> > index 0000000..16800de
> >> > --- /dev/null
> >> > +++ b/configs/Colombus_defconfig
> >> > @@ -0,0 +1,4 @@
> >> > +CONFIG_SYS_EXTRA_OPTIONS="COLOMBUS"
> >>
> >> Does this do anything other than define an unused #define?
> >>
> >> Ah, I suppose eventually it will cause the inclusion of a suitable dram
> >> file. Really ought to start moving things out of SYS_EXTRA though, but I
> >> don't think you need to shave that yakk just to get this patch in, so:
> >>
> >> Acked-by: Ian Campbell <ijc@hellion.org.uk>
> >
> > Although I've just noticed that lacks a board/sunxi/MAINTAINERS entry.
> >
> > I think there is no need to resend the whole series, just this one
> > patch. With this minor tweak I think it's time add this to
> > u-boot-sunxi#next.
>
> Actually I don't have this board. I think Maxime has one. Not sure
> if anyone else does. It was kind of a placeholder for all A31 boards.
>
> I suppose you could just drop this patch. I can send another one
> for the A31 Hummingbird, which I do have and can maintain.

Unless Maxime agrees to having his name in the MAINTAINERS file I think
that would be best, actually if he does agree I see no reason not to
have both ;-)

Ian.