public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot]  [PATCH] cmd_mmc: fix bootpart-resize maxarg to 4
@ 2014-09-25  0:35 Wally Yeh
  2014-10-03 14:20 ` Pantelis Antoniou
  0 siblings, 1 reply; 4+ messages in thread
From: Wally Yeh @ 2014-09-25  0:35 UTC (permalink / raw)
  To: u-boot

sub-command 'bootpart-resize' check for argc == 4,
it will retrun CMD_RET_FAILURE when argc value not matched.

but bootpart-resize's maxarg is 3, which means you never execute
this sub-command successfully.

fix it by change bootpart-resize maxarg to 4.

Signed-off-by: wally.yeh <wally.yeh@atrustcorp.com>
---
 common/cmd_mmc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c
index 1e40983..4286e26 100644
--- a/common/cmd_mmc.c
+++ b/common/cmd_mmc.c
@@ -602,7 +602,7 @@ static cmd_tbl_t cmd_mmc[] = {
  U_BOOT_CMD_MKENT(list, 1, 1, do_mmc_list, "", ""),
 #ifdef CONFIG_SUPPORT_EMMC_BOOT
  U_BOOT_CMD_MKENT(bootbus, 5, 0, do_mmc_bootbus, "", ""),
- U_BOOT_CMD_MKENT(bootpart-resize, 3, 0, do_mmc_boot_resize, "", ""),
+ U_BOOT_CMD_MKENT(bootpart-resize, 4, 0, do_mmc_boot_resize, "", ""),
  U_BOOT_CMD_MKENT(partconf, 5, 0, do_mmc_partconf, "", ""),
  U_BOOT_CMD_MKENT(rst-function, 3, 0, do_mmc_rst_func, "", ""),
 #endif
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot]  [PATCH] cmd_mmc: fix bootpart-resize maxarg to 4
@ 2014-09-25 15:00 Wally Yeh
  2014-09-25 19:05 ` DEATHX
  0 siblings, 1 reply; 4+ messages in thread
From: Wally Yeh @ 2014-09-25 15:00 UTC (permalink / raw)
  To: u-boot

sub-command 'bootpart-resize' check for argc == 4,
it will retrun CMD_RET_FAILURE when argc value not matched.

but bootpart-resize's maxarg is 3, which means you never execute
this sub-command successfully.

fix it by change bootpart-resize maxarg to 4.

Signed-off-by: wally.yeh <wally.yeh@atrustcorp.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Pierre Aubert <p.aubert@staubli.com>
---
 common/cmd_mmc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c
index 1e40983..4286e26 100644
--- a/common/cmd_mmc.c
+++ b/common/cmd_mmc.c
@@ -602,7 +602,7 @@ static cmd_tbl_t cmd_mmc[] = {
  U_BOOT_CMD_MKENT(list, 1, 1, do_mmc_list, "", ""),
 #ifdef CONFIG_SUPPORT_EMMC_BOOT
  U_BOOT_CMD_MKENT(bootbus, 5, 0, do_mmc_bootbus, "", ""),
- U_BOOT_CMD_MKENT(bootpart-resize, 3, 0, do_mmc_boot_resize, "", ""),
+ U_BOOT_CMD_MKENT(bootpart-resize, 4, 0, do_mmc_boot_resize, "", ""),
  U_BOOT_CMD_MKENT(partconf, 5, 0, do_mmc_partconf, "", ""),
  U_BOOT_CMD_MKENT(rst-function, 3, 0, do_mmc_rst_func, "", ""),
 #endif
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] cmd_mmc: fix bootpart-resize maxarg to 4
  2014-09-25 15:00 [U-Boot] [PATCH] cmd_mmc: fix bootpart-resize maxarg to 4 Wally Yeh
@ 2014-09-25 19:05 ` DEATHX
  0 siblings, 0 replies; 4+ messages in thread
From: DEATHX @ 2014-09-25 19:05 UTC (permalink / raw)
  To: u-boot

sorry for send this patch two times, It shows being held until the list
moderator can review it for approval.

I think maybe I didn't register the correct mail address and sent it
again. but it still show wait for moderator review.

At last I register my private mail address to this list and found I have
post the same post two time. 

I'm so sorry for this mistake.

Wally

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] cmd_mmc: fix bootpart-resize maxarg to 4
  2014-09-25  0:35 Wally Yeh
@ 2014-10-03 14:20 ` Pantelis Antoniou
  0 siblings, 0 replies; 4+ messages in thread
From: Pantelis Antoniou @ 2014-10-03 14:20 UTC (permalink / raw)
  To: u-boot

Hi Wally,

On Sep 25, 2014, at 3:35 AM, Wally Yeh <wally.yeh@atrustcorp.com> wrote:

> sub-command 'bootpart-resize' check for argc == 4,
> it will retrun CMD_RET_FAILURE when argc value not matched.
> 
> but bootpart-resize's maxarg is 3, which means you never execute
> this sub-command successfully.
> 
> fix it by change bootpart-resize maxarg to 4.
> 
> Signed-off-by: wally.yeh <wally.yeh@atrustcorp.com>
> ---
> common/cmd_mmc.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c
> index 1e40983..4286e26 100644
> --- a/common/cmd_mmc.c
> +++ b/common/cmd_mmc.c
> @@ -602,7 +602,7 @@ static cmd_tbl_t cmd_mmc[] = {
>  U_BOOT_CMD_MKENT(list, 1, 1, do_mmc_list, "", ""),
> #ifdef CONFIG_SUPPORT_EMMC_BOOT
>  U_BOOT_CMD_MKENT(bootbus, 5, 0, do_mmc_bootbus, "", ""),
> - U_BOOT_CMD_MKENT(bootpart-resize, 3, 0, do_mmc_boot_resize, "", ""),
> + U_BOOT_CMD_MKENT(bootpart-resize, 4, 0, do_mmc_boot_resize, "", ""),
>  U_BOOT_CMD_MKENT(partconf, 5, 0, do_mmc_partconf, "", ""),
>  U_BOOT_CMD_MKENT(rst-function, 3, 0, do_mmc_rst_func, "", ""),
> #endif
> -- 
> 1.7.10.4

Thanks, applied.

Acked-by: Pantelis Antoniou <panto@antoniou-consulting.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-10-03 14:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-25 15:00 [U-Boot] [PATCH] cmd_mmc: fix bootpart-resize maxarg to 4 Wally Yeh
2014-09-25 19:05 ` DEATHX
  -- strict thread matches above, loose matches on Subject: below --
2014-09-25  0:35 Wally Yeh
2014-10-03 14:20 ` Pantelis Antoniou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox