From: Georges Savoundararadj <savoundg@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] arm: make .vectors section allocatable
Date: Sat, 27 Sep 2014 21:48:09 +0200 [thread overview]
Message-ID: <1411847291-1790-2-git-send-email-savoundg@gmail.com> (raw)
In-Reply-To: <1411847291-1790-1-git-send-email-savoundg@gmail.com>
A regression was introduced in commit 41623c91. The consequence of that
is the non-relocation of the section .vectors symbols :
_undefined_instruction, _software_interrupt, _prefetch_abort,
_data_abort, _not_used, _irq and _fiq.
Before commit 41623c91, the exception vectors were in a .text section.
The .text section has the attributes allocatable and executable [1].
In commit 41623c91, a specific section is created, called .vectors, with
the attribute executable only.
What have changed between commit 41623c91^ and 41623c91 is the attribute
of the section which contains the exception vectors.
An allocatable section is "a section [that] occupies memory during
process execution" [1] which is the case of the section .vectors.
Adding the lacking attribute (SHF_ALLOC or "a") for the definition of
the section .vectors fixed the issue.
To summarize, the fix has to mark .vectors as allocatable because the
exception vectors reside in "memory during execution" and they need to
be relocated.
[1] http://man7.org/linux/man-pages/man5/elf.5.html
Signed-off-by: Georges Savoundararadj <savoundg@gmail.com>
Cc: Albert Aribeau <albert.u.boot@aribaud.net>
---
Changes in v2:
- Reword the commit message
arch/arm/lib/vectors.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
index 0cb87ce..49238ed 100644
--- a/arch/arm/lib/vectors.S
+++ b/arch/arm/lib/vectors.S
@@ -33,7 +33,7 @@
*************************************************************************
*/
- .section ".vectors", "x"
+ .section ".vectors", "ax"
/*
*************************************************************************
--
2.1.0
next prev parent reply other threads:[~2014-09-27 19:48 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 21:33 [U-Boot] [PATCH 0/3] arm: add interrupt support Georges Savoundararadj
2014-09-21 21:33 ` [U-Boot] [PATCH 1/3] arm: make .vectors section allocatable Georges Savoundararadj
2014-09-24 7:34 ` Albert ARIBAUD
2014-09-25 20:11 ` Georges Savoundararadj
2014-09-21 21:33 ` [U-Boot] [PATCH 2/3] arm1176: move exception vectors after relocation Georges Savoundararadj
2014-09-21 21:33 ` [U-Boot] [PATCH 3/3] arm: enable_interrupts: set sp in IRQ/FIQ modes Georges Savoundararadj
2014-09-22 1:35 ` [U-Boot] [PATCH 0/3] arm: add interrupt support Masahiro Yamada
2014-09-22 18:24 ` Georges Savoundararadj
2014-09-23 3:17 ` Masahiro YAMADA
2014-09-24 7:20 ` Albert ARIBAUD
2014-09-24 7:22 ` Albert ARIBAUD
2014-09-27 19:48 ` [U-Boot] [PATCH v2 0/3] arm: fix exception handling Georges Savoundararadj
2014-09-27 19:48 ` Georges Savoundararadj [this message]
2014-09-27 19:48 ` [U-Boot] [PATCH v2 2/3] arm: relocate the exception vectors Georges Savoundararadj
2014-10-11 10:47 ` Albert ARIBAUD
2014-10-14 20:02 ` Georges Savoundararadj
2014-10-14 22:11 ` Albert ARIBAUD
2014-10-20 21:08 ` Georges Savoundararadj
2014-10-21 5:41 ` Masahiro Yamada
2014-10-21 14:05 ` Albert ARIBAUD
2014-10-22 9:50 ` Masahiro Yamada
2014-10-22 20:29 ` Georges Savoundararadj
2014-10-21 13:54 ` Albert ARIBAUD
2014-10-22 9:54 ` Masahiro Yamada
2014-10-22 20:52 ` Georges Savoundararadj
2014-09-27 19:58 ` [U-Boot] [PATCH v2 3/3] arm: interrupt_init: set sp in IRQ/FIQ modes Georges Savoundararadj
2014-10-26 22:25 ` [U-Boot] [PATCH v3 0/4] arm: fix exception handling Georges Savoundararadj
2014-10-26 22:25 ` [U-Boot] [PATCH v3 1/4] kconfig: arm: introduce symbol for ARM CPUs Georges Savoundararadj
2014-10-27 16:50 ` Masahiro YAMADA
2014-10-27 17:09 ` Albert ARIBAUD
2014-10-27 17:23 ` Masahiro YAMADA
2014-10-28 7:01 ` Albert ARIBAUD
2014-10-28 16:10 ` Masahiro YAMADA
2014-10-28 15:57 ` Masahiro YAMADA
2014-10-28 18:58 ` Georges Savoundararadj
2014-10-26 22:25 ` [U-Boot] [PATCH v3 2/4] arm: make .vectors section allocatable Georges Savoundararadj
2014-10-26 23:20 ` Albert ARIBAUD
2014-10-26 22:25 ` [U-Boot] [PATCH v3 3/4] arm: relocate the exception vectors Georges Savoundararadj
2014-10-26 22:25 ` [U-Boot] [PATCH v3 4/4] arm: interrupt_init: set sp in IRQ/FIQ modes Georges Savoundararadj
2014-10-26 23:16 ` Albert ARIBAUD
2014-10-26 23:32 ` Albert ARIBAUD
2014-10-28 22:16 ` [U-Boot] [PATCH v4 0/4] arm: fix exception handling Georges Savoundararadj
2014-10-28 22:16 ` [U-Boot] [PATCH v4 1/4] kconfig: arm: introduce symbol for ARM CPUs Georges Savoundararadj
2014-10-29 8:07 ` Masahiro Yamada
2014-10-29 12:37 ` Tom Rini
2014-10-29 12:50 ` Albert ARIBAUD
2014-10-29 15:22 ` Tom Rini
2014-10-28 22:16 ` [U-Boot] [PATCH v4 2/4] arm: make .vectors section allocatable Georges Savoundararadj
2014-10-29 12:49 ` Albert ARIBAUD
2014-10-29 15:22 ` Tom Rini
2014-10-28 22:16 ` [U-Boot] [PATCH v4 3/4] arm: relocate the exception vectors Georges Savoundararadj
2014-10-29 12:49 ` Albert ARIBAUD
2014-10-29 15:22 ` Tom Rini
2014-10-28 22:16 ` [U-Boot] [PATCH v4 4/4] arm: interrupt_init: set sp in IRQ/FIQ modes Georges Savoundararadj
2014-10-29 12:49 ` Albert ARIBAUD
2014-10-29 15:22 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411847291-1790-2-git-send-email-savoundg@gmail.com \
--to=savoundg@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox