From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 13/13] mxc nand: Add support for i.MX5
Date: Sat, 17 Nov 2012 02:43:03 +0100 (CET) [thread overview]
Message-ID: <1412352961.1504022.1353116583053.JavaMail.root@advansee.com> (raw)
In-Reply-To: <1353110463.13910.7@snotra>
Hi Scott,
On Saturday, November 17, 2012 1:01:03 AM, Scott Wood wrote:
> On 11/16/2012 02:28:16 PM, Beno?t Th?baudeau wrote:
> > Also, I've noticed that some of the oobfree fields of the
> > nand_ecclayout
> > structures in mxc_nand.c are slightly different from what can be
> > found in Linux.
> > Any idea about which one is correct (if any)?
>
> Unless there's an obvious error such as overlap with ECC or a bad
> block
> marker, there isn't really a right answer (except to the extent that
> you're wasting bytes) -- but it's important that everyone agree. So
> the answer is basically, "which compatibility would it hurt more to
> break?"
>
> That said, the U-Boot ones make more sense to me in terms of not
> having
> strange missing bytes.
I've just found this commit, which explains what's going on:
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=8c1fd89a85f898384df02217c09c98c2f39b4832
It looks like Linux is correct here because each structure is used for both 8-
and 16-bit NFs, which seem to have different locations for bad block markers.
This fix is also missing from U-Boot:
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=6c49939869c20550512386610ece45aceb65e7f4
It would help to drop some of the pagesize_2k that are weirdly mixed with
writesize.
Best regards,
Beno?t
next prev parent reply other threads:[~2012-11-17 1:43 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 20:47 [U-Boot] [PATCH 00/13] mxc nand: Add support for i.MX5 Benoît Thébaudeau
2012-08-13 20:48 ` [U-Boot] [PATCH 01/13] mxc nand: Merge mtd and spl register definitions Benoît Thébaudeau
2012-08-14 8:37 ` Stefano Babic
2012-08-14 10:15 ` Benoît Thébaudeau
2012-08-14 10:46 ` Stefano Babic
2012-08-14 11:13 ` Benoît Thébaudeau
2012-08-14 14:02 ` Stefano Babic
2012-08-14 14:29 ` Benoît Thébaudeau
2012-08-15 18:11 ` Benoît Thébaudeau
2012-08-16 7:27 ` Stefano Babic
2012-08-14 16:01 ` Scott Wood
2012-08-13 20:48 ` [U-Boot] [PATCH 02/13] mxc nand: cosmectic: Light cleanup Benoît Thébaudeau
2012-08-14 8:41 ` Stefano Babic
2012-08-13 20:48 ` [U-Boot] [PATCH 03/13] spl mxc nand: Merge duplicated code Benoît Thébaudeau
2012-08-14 9:25 ` Stefano Babic
2012-08-13 20:49 ` [U-Boot] [PATCH 04/13] spl mxc nand: Remove " Benoît Thébaudeau
2012-08-13 20:49 ` [U-Boot] [PATCH 05/13] spl mxc nand: Set symmetric mode Benoît Thébaudeau
2012-08-13 20:49 ` [U-Boot] [PATCH 06/13] mxc nand: Access all ecc_status_result fields Benoît Thébaudeau
2012-09-18 0:39 ` Scott Wood
2012-09-18 0:50 ` Scott Wood
2012-08-13 20:49 ` [U-Boot] [PATCH 07/13] spl mxc nand: Fix broken boot for correctable ECC errors Benoît Thébaudeau
2012-08-13 20:50 ` [U-Boot] [PATCH 08/13] mtd mxc nand: Use _mxc_nand_enable_hwecc() Benoît Thébaudeau
2012-08-14 8:50 ` Stefano Babic
2012-08-14 10:04 ` Benoît Thébaudeau
2012-08-13 20:50 ` [U-Boot] [PATCH 09/13] mtd mxc nand: Fix ECC state after read_page_raw_syndrome() Benoît Thébaudeau
2012-08-13 20:50 ` [U-Boot] [PATCH 10/13] mtd mxc nand: Merge init functions Benoît Thébaudeau
2012-08-13 20:50 ` [U-Boot] [PATCH 11/13] mxc nand: Let driver detect IP revision Benoît Thébaudeau
2012-08-14 9:28 ` Stefano Babic
2012-08-13 20:50 ` [U-Boot] [PATCH 12/13] mxc nand: Homogenize IP revisions with Linux Benoît Thébaudeau
2012-08-13 20:51 ` [U-Boot] [PATCH 13/13] mxc nand: Add support for i.MX5 Benoît Thébaudeau
2012-08-13 21:04 ` Troy Kisky
2012-08-13 21:06 ` Troy Kisky
2012-08-21 21:04 ` [U-Boot] [PATCH v2 " Benoît Thébaudeau
2012-08-21 21:21 ` Scott Wood
2012-09-18 0:36 ` Scott Wood
2012-09-18 18:11 ` Tom Rini
2012-11-15 22:22 ` Scott Wood
2012-11-16 20:15 ` Benoît Thébaudeau
2012-11-16 20:18 ` Scott Wood
2012-11-16 20:19 ` Scott Wood
2012-11-16 20:28 ` Benoît Thébaudeau
2012-11-17 0:01 ` Scott Wood
2012-11-17 1:43 ` Benoît Thébaudeau [this message]
2012-11-20 23:03 ` Scott Wood
2012-11-20 23:31 ` Benoît Thébaudeau
2012-11-17 18:37 ` Fabio Estevam
2012-11-20 20:33 ` Matt Sealey
2012-09-18 1:01 ` Scott Wood
2012-09-18 10:18 ` Benoît Thébaudeau
2012-09-18 1:19 ` [U-Boot] [PATCH 00/13] " Scott Wood
2013-01-07 13:02 ` Marek Vasut
2013-01-07 13:37 ` Benoît Thébaudeau
2013-01-07 13:47 ` Marek Vasut
2013-01-08 0:49 ` Scott Wood
2013-01-08 6:59 ` Marek Vasut
2013-01-07 14:36 ` Fabio Estevam
2013-01-07 15:08 ` Marek Vasut
2013-01-07 15:30 ` Benoît Thébaudeau
2013-01-07 15:33 ` Marek Vasut
2013-01-07 16:42 ` Marek Vasut
2013-01-07 16:55 ` Benoît Thébaudeau
2013-01-08 7:15 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412352961.1504022.1353116583053.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox