From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Date: Sat, 17 Nov 2012 02:43:03 +0100 (CET) Subject: [U-Boot] [PATCH v2 13/13] mxc nand: Add support for i.MX5 In-Reply-To: <1353110463.13910.7@snotra> Message-ID: <1412352961.1504022.1353116583053.JavaMail.root@advansee.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Scott, On Saturday, November 17, 2012 1:01:03 AM, Scott Wood wrote: > On 11/16/2012 02:28:16 PM, Beno?t Th?baudeau wrote: > > Also, I've noticed that some of the oobfree fields of the > > nand_ecclayout > > structures in mxc_nand.c are slightly different from what can be > > found in Linux. > > Any idea about which one is correct (if any)? > > Unless there's an obvious error such as overlap with ECC or a bad > block > marker, there isn't really a right answer (except to the extent that > you're wasting bytes) -- but it's important that everyone agree. So > the answer is basically, "which compatibility would it hurt more to > break?" > > That said, the U-Boot ones make more sense to me in terms of not > having > strange missing bytes. I've just found this commit, which explains what's going on: http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=8c1fd89a85f898384df02217c09c98c2f39b4832 It looks like Linux is correct here because each structure is used for both 8- and 16-bit NFs, which seem to have different locations for bad block markers. This fix is also missing from U-Boot: http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=6c49939869c20550512386610ece45aceb65e7f4 It would help to drop some of the pagesize_2k that are weirdly mixed with writesize. Best regards, Beno?t