public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] sunxi: Turn MMC_SUNXI_SLOT_EXTRA into a proper Kconfig option
Date: Sat, 04 Oct 2014 09:32:08 +0100	[thread overview]
Message-ID: <1412411528.17796.58.camel@hellion.org.uk> (raw)
In-Reply-To: <1412348759-4599-4-git-send-email-hdegoede@redhat.com>

On Fri, 2014-10-03 at 17:05 +0200, Hans de Goede wrote:
> Note we also drop the SPL check for initializing the 2nd mmc slot, the SPL
> check is not necessary with Kconfig, because only options explicitly marked
> as also being for the SPL get set during SPL builds.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

If we come across a system with e.g. 3 slots then this is just going to
get more complex, isn't it? Shall we bite the bullet now and got
straight to a bool option per potential slot?

> ---
>  board/sunxi/Kconfig | 8 ++++++++
>  board/sunxi/board.c | 2 +-
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
> index 72d6dfa..c9b459a 100644
> --- a/board/sunxi/Kconfig
> +++ b/board/sunxi/Kconfig
> @@ -32,6 +32,14 @@ config USB_KEYBOARD
>  	Say Y here to add support for using a USB keyboard (typically used
>  	in combination with a graphical console on HDMI).
>  
> +config MMC_SUNXI_SLOT_EXTRA
> +	int "mmc extra slot number"
> +	default -1
> +	---help---
> +	sunxi builds always enable mmc0, some boards also have a sdcard slot
> +	or emmc on mmc2 or mmc3. Setting this to 2 or 3 will enable support
> +	for this.
> +
>  config MMC0_CD_PIN
>  	int "Card detect pin for mmc0"
>  	default -1
> diff --git a/board/sunxi/board.c b/board/sunxi/board.c
> index e819b12..4d602ca 100644
> --- a/board/sunxi/board.c
> +++ b/board/sunxi/board.c
> @@ -110,7 +110,7 @@ int board_mmc_init(bd_t *bis)
>  {
>  	mmc_pinmux_setup(CONFIG_MMC_SUNXI_SLOT);
>  	sunxi_mmc_init(CONFIG_MMC_SUNXI_SLOT);
> -#if !defined (CONFIG_SPL_BUILD) && defined (CONFIG_MMC_SUNXI_SLOT_EXTRA)
> +#if CONFIG_MMC_SUNXI_SLOT_EXTRA != -1
>  	mmc_pinmux_setup(CONFIG_MMC_SUNXI_SLOT_EXTRA);
>  	sunxi_mmc_init(CONFIG_MMC_SUNXI_SLOT_EXTRA);
>  #endif

  reply	other threads:[~2014-10-04  8:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 15:05 [U-Boot] [PATCH 0/6] sunxi: Add second sdcard slot support, including eMMC boot Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 1/6] sunxi: Add sunxi_gpio_get_val function Hans de Goede
2014-10-04  8:14   ` Ian Campbell
2014-10-05 14:42     ` Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 2/6] sunxi: Add mmc card-detect functionality Hans de Goede
2014-10-04  8:30   ` Ian Campbell
2014-10-05 14:58     ` Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 3/6] sunxi: Turn MMC_SUNXI_SLOT_EXTRA into a proper Kconfig option Hans de Goede
2014-10-04  8:32   ` Ian Campbell [this message]
2014-10-05 15:00     ` Hans de Goede
2014-10-06  8:30       ` Ian Campbell
2014-10-03 15:05 ` [U-Boot] [PATCH 4/6] sunxi: When we've both mmc0 and mmc2, detect from which one we're booting Hans de Goede
2014-10-04  8:35   ` Ian Campbell
2014-10-05 15:10     ` Hans de Goede
2014-10-06  8:33       ` Ian Campbell
2014-10-06 14:23         ` Hans de Goede
2014-10-03 15:05 ` [U-Boot] [PATCH 5/6] sunxi: Use PG3 - PG8 as io-pins for mmc1 Hans de Goede
2014-10-04  8:37   ` Ian Campbell
2014-10-06  8:37     ` Hans de Goede
2014-10-06  8:42       ` Ian Campbell
2014-10-06 14:43     ` Hans de Goede
2014-10-06 15:42       ` Ian Campbell
2014-10-03 15:05 ` [U-Boot] [PATCH 6/6] sunxi: Enable second sdcard slot found on some boards Hans de Goede
2014-10-04  8:38   ` Ian Campbell
2014-10-04  8:39     ` Ian Campbell
2014-10-06  8:37       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412411528.17796.58.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox