public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH for-next 1/3] sunxi: Kconfig: Consolidate SYS_CONFIG_NAME settings
Date: Mon, 06 Oct 2014 09:23:39 +0100	[thread overview]
Message-ID: <1412583819.12695.41.camel@hellion.org.uk> (raw)
In-Reply-To: <54324962.6020802@redhat.com>

On Mon, 2014-10-06 at 09:48 +0200, Hans de Goede wrote:
> Hi,
> 
> On 10/04/2014 10:48 AM, Ian Campbell wrote:
> > No need to be so repetitive.
> 
> Hmm, I also have a version of this in my tree, I thought I had already send
> that out, but maybe I did not,

Ah, it seemed familiar as I was writing it, but I decided it had just
been discussed and not implemented.

> You need to move this up to the top of the Kconfig file, as it
> gets unconditionally sourced from arch/arm/Kconfig, and if this is
> not at the top, you will be unconditionally adding a SYS_CONFIG_NAME
> section which may conflict with other targets which also define it.

Makes sense.

> With that fixed this is:
> 
> Acked-by: Hans de Goede <hdegoede@redhat.com>

Thanks.
Ian.

  reply	other threads:[~2014-10-06  8:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-04  8:47 [U-Boot] [PATCH for-next 0/3] sunxi: Kconfig consolidation and cleanup Ian Campbell
2014-10-04  8:48 ` [U-Boot] [PATCH for-next 1/3] sunxi: Kconfig: Consolidate SYS_CONFIG_NAME settings Ian Campbell
2014-10-06  7:48   ` Hans de Goede
2014-10-06  8:23     ` Ian Campbell [this message]
2014-10-04  8:48 ` [U-Boot] [PATCH for-next 2/3] sunxi: kconfig: Add top-level TARGET_SUNXI Ian Campbell
2014-10-05  2:37   ` Chen-Yu Tsai
2014-10-06  1:39   ` Masahiro Yamada
2014-10-06  8:27     ` Ian Campbell
2014-10-06 10:54       ` Masahiro Yamada
2014-10-22 19:14         ` Ian Campbell
2014-10-24 11:46           ` Masahiro Yamada
2014-10-24 13:22             ` Ian Campbell
2014-10-24 14:04               ` Hans de Goede
2014-10-26 16:55               ` Masahiro YAMADA
2014-10-06  7:55   ` Hans de Goede
2014-10-04  8:48 ` [U-Boot] [PATCH for-next 3/3] sunxi: Kconfig: Make SPL_FEL a toplevel Kconfig option Ian Campbell
2014-10-06  7:58   ` Hans de Goede
2014-10-06  8:28     ` Ian Campbell
2014-10-06  8:43       ` Hans de Goede
2014-10-04  9:32 ` [U-Boot] [PATCH for-next 0/3] sunxi: Kconfig consolidation and cleanup Ian Campbell
2014-10-06  2:16   ` Masahiro Yamada
2014-10-06  8:22     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412583819.12695.41.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox