public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/5] sunxi: Use PG3 - PG8 as io-pins for mmc1
Date: Sat, 11 Oct 2014 16:44:31 +0100	[thread overview]
Message-ID: <1413042271.11505.32.camel@hellion.org.uk> (raw)
In-Reply-To: <1412618265-4053-5-git-send-email-hdegoede@redhat.com>

On Mon, 2014-10-06 at 19:57 +0200, Hans de Goede wrote:
> None of the known sunxi devices actually use mmc1 routed through PH, where
> as some devices do actually use mmc1 routed through PG, so change the routing
> of mmc1 to PG. If in the future we encounter devices with mmc1 routed through
> PH, we will need to change things to be a bit more flexible.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

(right address this time ;-))

> ---
>  arch/arm/include/asm/arch-sunxi/gpio.h | 2 ++
>  board/sunxi/board.c                    | 6 +++---
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-sunxi/gpio.h b/arch/arm/include/asm/arch-sunxi/gpio.h
> index f7f3d8c..3f46f78 100644
> --- a/arch/arm/include/asm/arch-sunxi/gpio.h
> +++ b/arch/arm/include/asm/arch-sunxi/gpio.h
> @@ -117,6 +117,8 @@ enum sunxi_gpio_number {
>  #define SUN5I_GPB19_UART0_TX	2
>  #define SUN5I_GPB20_UART0_RX	2
>  
> +#define SUN5I_GPG3_SDC1		2
> +
>  #define SUN5I_GPG3_UART1_TX	4
>  #define SUN5I_GPG4_UART1_RX	4
>  
> diff --git a/board/sunxi/board.c b/board/sunxi/board.c
> index 0a7be31..23f8887 100644
> --- a/board/sunxi/board.c
> +++ b/board/sunxi/board.c
> @@ -75,9 +75,9 @@ static void mmc_pinmux_setup(int sdc)
>  		break;
>  
>  	case 1:
> -		/* CMD-PH22, CLK-PH23, D0~D3-PH24~27 : 5 */
> -		for (pin = SUNXI_GPH(22); pin <= SUNXI_GPH(27); pin++) {
> -			sunxi_gpio_set_cfgpin(pin, SUN4I_GPH22_SDC1);
> +		/* CMD-PG3, CLK-PG4, D0~D3-PG5-8 */
> +		for (pin = SUNXI_GPG(3); pin <= SUNXI_GPG(8); pin++) {
> +			sunxi_gpio_set_cfgpin(pin, SUN5I_GPG3_SDC1);
>  			sunxi_gpio_set_pull(pin, SUNXI_GPIO_PULL_UP);
>  			sunxi_gpio_set_drv(pin, 2);
>  		}

  reply	other threads:[~2014-10-11 15:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-06 17:57 [U-Boot] [PATCH v2 0/5] sunxi: Enable second sdcard slot found on some boards Hans de Goede
2014-10-06 17:57 ` [U-Boot] [PATCH v2 1/5] sunxi: Add mmc card-detect functionality Hans de Goede
2014-10-11 15:39   ` Ian Campbell
2014-10-12  8:30     ` Hans de Goede
2014-10-06 17:57 ` [U-Boot] [PATCH v2 2/5] sunxi: Turn MMC_SUNXI_SLOT_EXTRA into a proper Kconfig option Hans de Goede
2014-10-11 15:40   ` Ian Campbell
2014-10-12  8:32     ` Hans de Goede
2014-10-06 17:57 ` [U-Boot] [PATCH v2 3/5] sunxi: When we've both mmc0 and mmc2, detect from which one we're booting Hans de Goede
2014-10-11 15:43   ` Ian Campbell
2014-10-12  9:20     ` Hans de Goede
2014-10-06 17:57 ` [U-Boot] [PATCH v2 4/5] sunxi: Use PG3 - PG8 as io-pins for mmc1 Hans de Goede
2014-10-11 15:44   ` Ian Campbell [this message]
2014-10-06 17:57 ` [U-Boot] [PATCH v2 5/5] sunxi: Enable second sdcard slot found on some boards Hans de Goede
2014-10-11 15:47   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413042271.11505.32.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox