public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "sunxi: dram: Use divisor P=1 for PLL5"
Date: Wed, 22 Oct 2014 10:42:39 +0100	[thread overview]
Message-ID: <1413970959.20604.64.camel@hellion.org.uk> (raw)
In-Reply-To: <54477860.40701@redhat.com>

On Wed, 2014-10-22 at 11:26 +0200, Hans de Goede wrote:
> Hi,
> 
> On 10/22/2014 11:19 AM, Ian Campbell wrote:
> > On Wed, 2014-10-22 at 10:35 +0200, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 10/22/2014 10:14 AM, Ian Campbell wrote:
> >>> On Tue, 2014-10-21 at 16:58 -0400, Tom Rini wrote:
> >>>> We should be doing things right, in mainline.  To bring up a different
> >>>> example, on TI OMAP4 parts at least for a long time in order to use
> >>>> mainline U-Boot on older kernels you had to manually add
> >>>> CONFIG_SOMETHING_OR_ANOTHER to enable additional clocks/mux that the old
> >>>> kernels had incorrectly relied on U-Boot to set.  If we must do strange
> >>>> things to support old and incorrect but in the wild kernels we need to
> >>>> (a) make it opt-in (easier now with Kconfig!) and (b) schedule a removal
> >>>> of the hack all the same.
> >>>
> >>> A Kconfig option does sound like a reasonable compromise.
> >>
> >> Ok, I will look into this, my plan for now is to call it OLD_KERNEL_COMPAT,
> >> so that if we come across more cases like this we've one config option for
> >> them, rather then a ton of small isolated config options.
> > 
> > Is it particular to "old" kernels as such, or is it more to do with
> > Allwinner SDK (and derived) kernels? Is it worth trying to keep
> > workarounds for such kernels separated from workarounds for old mainline
> > kernels?
> 
> AFAIK the first mainline kernels with sunxi support are recent enough that they
> don't need any workarounds. TBH I don't think differentiating between the 2
> brings us anything.

OK.

Ian.

      reply	other threads:[~2014-10-22  9:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15 10:12 [U-Boot] [PATCH] Revert "sunxi: dram: Use divisor P=1 for PLL5" Hans de Goede
2014-10-15 10:34 ` Siarhei Siamashka
2014-10-16  8:48   ` Hans de Goede
2014-10-16  9:49     ` Ian Campbell
2014-10-16  9:59     ` Siarhei Siamashka
2014-10-16 20:10     ` Jeroen Hofstee
2014-10-21 20:58     ` Tom Rini
2014-10-22  8:14       ` Ian Campbell
2014-10-22  8:35         ` Hans de Goede
2014-10-22  9:19           ` Ian Campbell
2014-10-22  9:26             ` Hans de Goede
2014-10-22  9:42               ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413970959.20604.64.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox