* [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set
@ 2014-10-22 13:45 Hans de Goede
2014-10-22 18:57 ` Ian Campbell
2014-10-22 19:24 ` Tom Rini
0 siblings, 2 replies; 6+ messages in thread
From: Hans de Goede @ 2014-10-22 13:45 UTC (permalink / raw)
To: u-boot
Old kernels cannot handle booting in non-secure (hyp) mode, so when
CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT.
Note that whether to booting secure or non-secure can always be overriden
using the bootm_boot_mode environment variable.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
include/configs/sun7i.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/configs/sun7i.h b/include/configs/sun7i.h
index 966cbd8..4a864b2 100644
--- a/include/configs/sun7i.h
+++ b/include/configs/sun7i.h
@@ -35,6 +35,10 @@
#define CONFIG_ARMV7_PSCI 1
#define CONFIG_ARMV7_PSCI_NR_CPUS 2
#define CONFIG_ARMV7_SECURE_BASE SUNXI_SRAM_B_BASE
+#ifdef CONFIG_OLD_KERNEL_COMPAT
+#define CONFIG_ARMV7_SEC_BY_DEFAULT 1
+#endif
+
#define CONFIG_SYS_CLK_FREQ 24000000
/*
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set
2014-10-22 13:45 [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set Hans de Goede
@ 2014-10-22 18:57 ` Ian Campbell
2014-10-23 8:52 ` Hans de Goede
2014-10-22 19:24 ` Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2014-10-22 18:57 UTC (permalink / raw)
To: u-boot
On Wed, 2014-10-22 at 15:45 +0200, Hans de Goede wrote:
> Old kernels cannot handle booting in non-secure (hyp) mode, so when
> CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT.
>
> Note that whether to booting secure or non-secure can always be overriden
nits: "boot" (not booting, or s/whether to/ perhaps) and "overridden"
> using the bootm_boot_mode environment variable.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> include/configs/sun7i.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/configs/sun7i.h b/include/configs/sun7i.h
> index 966cbd8..4a864b2 100644
> --- a/include/configs/sun7i.h
> +++ b/include/configs/sun7i.h
> @@ -35,6 +35,10 @@
> #define CONFIG_ARMV7_PSCI 1
> #define CONFIG_ARMV7_PSCI_NR_CPUS 2
> #define CONFIG_ARMV7_SECURE_BASE SUNXI_SRAM_B_BASE
> +#ifdef CONFIG_OLD_KERNEL_COMPAT
> +#define CONFIG_ARMV7_SEC_BY_DEFAULT 1
> +#endif
I think this would be better right after the NONSEC+VIRT defines just
above the context here, since they are related.
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set
2014-10-22 13:45 [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set Hans de Goede
2014-10-22 18:57 ` Ian Campbell
@ 2014-10-22 19:24 ` Tom Rini
2014-10-23 8:52 ` Hans de Goede
1 sibling, 1 reply; 6+ messages in thread
From: Tom Rini @ 2014-10-22 19:24 UTC (permalink / raw)
To: u-boot
On Wed, Oct 22, 2014 at 03:45:23PM +0200, Hans de Goede wrote:
> Old kernels cannot handle booting in non-secure (hyp) mode, so when
> CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT.
>
> Note that whether to booting secure or non-secure can always be overriden
> using the bootm_boot_mode environment variable.
This belongs in Kconfig. If you want to make it really optional all the
same, make modifying it depend on CONFIG_EXPERT too.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141022/9275f28c/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set
2014-10-22 19:24 ` Tom Rini
@ 2014-10-23 8:52 ` Hans de Goede
2014-10-23 13:10 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2014-10-23 8:52 UTC (permalink / raw)
To: u-boot
Hi Tom,
On 10/22/2014 09:24 PM, Tom Rini wrote:
> On Wed, Oct 22, 2014 at 03:45:23PM +0200, Hans de Goede wrote:
>
>> Old kernels cannot handle booting in non-secure (hyp) mode, so when
>> CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT.
>>
>> Note that whether to booting secure or non-secure can always be overriden
>> using the bootm_boot_mode environment variable.
>
> This belongs in Kconfig. If you want to make it really optional all the
> same, make modifying it depend on CONFIG_EXPERT too.
I understand where your coming from, but the problem is that
CONFIG_ARMV7_SEC_BY_DEFAULT as a Kconfig option should depend on
CONFIG_ARMV7_VIRT or CONFIG_ARMV7_NONSEC, which depend on
CONFIG_ARMV7_PSCI / CONFIG_ARMV7_PSCI_NR_CPUS and
CONFIG_ARMV7_SECURE_BASE, all of which are currently set
through include/configs/foo.h.
I know that the plan is to move all of these to Kconfig eventually,
but there still is a lot of figuring out how that exactly should be
done, and as such I believe that it is best to set
CONFIG_ARMV7_SEC_BY_DEFAULT the "old-fashioned" way for now.
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set
2014-10-22 18:57 ` Ian Campbell
@ 2014-10-23 8:52 ` Hans de Goede
0 siblings, 0 replies; 6+ messages in thread
From: Hans de Goede @ 2014-10-23 8:52 UTC (permalink / raw)
To: u-boot
Hi,
On 10/22/2014 08:57 PM, Ian Campbell wrote:
> On Wed, 2014-10-22 at 15:45 +0200, Hans de Goede wrote:
>> Old kernels cannot handle booting in non-secure (hyp) mode, so when
>> CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT.
>>
>> Note that whether to booting secure or non-secure can always be overriden
>
> nits: "boot" (not booting, or s/whether to/ perhaps) and "overridden"
>
>> using the bootm_boot_mode environment variable.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> include/configs/sun7i.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/include/configs/sun7i.h b/include/configs/sun7i.h
>> index 966cbd8..4a864b2 100644
>> --- a/include/configs/sun7i.h
>> +++ b/include/configs/sun7i.h
>> @@ -35,6 +35,10 @@
>> #define CONFIG_ARMV7_PSCI 1
>> #define CONFIG_ARMV7_PSCI_NR_CPUS 2
>> #define CONFIG_ARMV7_SECURE_BASE SUNXI_SRAM_B_BASE
>> +#ifdef CONFIG_OLD_KERNEL_COMPAT
>> +#define CONFIG_ARMV7_SEC_BY_DEFAULT 1
>> +#endif
>
> I think this would be better right after the NONSEC+VIRT defines just
> above the context here, since they are related.
Fixed in my personal tree, I'll do a v2 as soon as the Kconfig
question Tom raised is answered.
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set
2014-10-23 8:52 ` Hans de Goede
@ 2014-10-23 13:10 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2014-10-23 13:10 UTC (permalink / raw)
To: u-boot
On Thu, Oct 23, 2014 at 10:52:23AM +0200, Hans de Goede wrote:
> Hi Tom,
>
> On 10/22/2014 09:24 PM, Tom Rini wrote:
> > On Wed, Oct 22, 2014 at 03:45:23PM +0200, Hans de Goede wrote:
> >
> >> Old kernels cannot handle booting in non-secure (hyp) mode, so when
> >> CONFIG_OLD_KERNEL_COMPAT is set, also set CONFIG_ARMV7_SEC_BY_DEFAULT.
> >>
> >> Note that whether to booting secure or non-secure can always be overriden
> >> using the bootm_boot_mode environment variable.
> >
> > This belongs in Kconfig. If you want to make it really optional all the
> > same, make modifying it depend on CONFIG_EXPERT too.
>
> I understand where your coming from, but the problem is that
> CONFIG_ARMV7_SEC_BY_DEFAULT as a Kconfig option should depend on
> CONFIG_ARMV7_VIRT or CONFIG_ARMV7_NONSEC, which depend on
> CONFIG_ARMV7_PSCI / CONFIG_ARMV7_PSCI_NR_CPUS and
> CONFIG_ARMV7_SECURE_BASE, all of which are currently set
> through include/configs/foo.h.
True, but lets fix it. Ideally, we would have something to select
"ARMV7", but we don't yet, and I won't make that your pre-req. All of
the above options are only used by sunxi and arndale and vexpress right
now. Add arch/arm/cpu/armv7/Kconfig for the above ARMv7 options, source
it from arch/arm/Kconfig and make the contents be on if ARNDALE || CA15
|| SUNXI with a comment on needing to clean this up further once we have
more fine-grained selects on SoC features.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141023/d4b4dc69/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-23 13:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-22 13:45 [U-Boot] [PATCH] sun7i: Set CONFIG_ARMV7_SEC_BY_DEFAULT when CONFIG_OLD_KERNEL_COMPAT is set Hans de Goede
2014-10-22 18:57 ` Ian Campbell
2014-10-23 8:52 ` Hans de Goede
2014-10-22 19:24 ` Tom Rini
2014-10-23 8:52 ` Hans de Goede
2014-10-23 13:10 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox