public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH for-next 2/3] sunxi: kconfig: Add top-level TARGET_SUNXI
Date: Fri, 24 Oct 2014 14:22:30 +0100	[thread overview]
Message-ID: <1414156950.15687.44.camel@hellion.org.uk> (raw)
In-Reply-To: <20141024204646.CF7F.AA925319@jp.panasonic.com>

On Fri, 2014-10-24 at 20:46 +0900, Masahiro Yamada wrote:
> Hi Ian,
> 
> 
> On Wed, 22 Oct 2014 20:14:29 +0100
> Ian Campbell <ijc@hellion.org.uk> wrote:
> 
> > On Mon, 2014-10-06 at 19:54 +0900, Masahiro Yamada wrote:
> > > Hi Ian
> > > 
> > > On Mon, 06 Oct 2014 09:27:19 +0100
> > > Ian Campbell <ijc@hellion.org.uk> wrote:
> > > Hi Ian,
> > > 
> > > > On Mon, 2014-10-06 at 10:39 +0900, Masahiro Yamada wrote:
> > > > > Hi Ian,
> > > > > 
> > > > > On Sat,  4 Oct 2014 09:48:11 +0100
> > > > > Ian Campbell <ijc@hellion.org.uk> wrote:
> > > > > 
> > > > > > And make TARGET_SUN[457]I a choice variable under this.
> > > > > > 
> > > > > > configs updated with:
> > > > > >     sed -i -e 's/^\+S:CONFIG_TARGET_SUN.I=y/+S:CONFIG_TARGET_SUNXI=y\n&/g' configs/*
> > > > > > 
> > > > > > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> > > > > 
> > > > > 
> > > > > Perhaps, is ARCH_SUNXI more familiar?
> > > > 
> > > > I've no idea ;-)
> > > > 
> > > > I think this is something which ought to be consistent within u-boot as
> > > > a whole. Seems we have a mixture of ARCH_FOO (DAVINCI, VERSATILE,
> > > > EXYNOS) and just FOO (TEGRA, ZYNQ). It does look like TARGET_FOO is all
> > > > individual boards though, which would make it inappropriate for SUNXI or
> > > > even SUN[4567]I.
> > > 
> > > SoC/board select menu clean-up is on the way.
> > > I have to admit the naming convention is inconsistent now.
> > > 
> > > CONFIG_ARCH_{DAVINCI, VERSATILE, EXYNOS} were added recently.
> > > If Xilinx/NVIDIA developers argree, we can rename
> > > CONFIG_{TEGRA, ZYNQ} -> CONFIG_ARCH_{TEGRA, ZYNQ} at some point.
> > 
> > So we want CONFIG_ARCH_SUNXI as well as CONFIG_ARCH_SUN[45678]I? Or did
> > you mean for the latter to remain CONFIG_TARGET_SUN[45678]I?
> 
> 
> I think the latter should remain CONFIG_TARGET_*.
> Or I think it is also OK to follow arch/arm/mach-sunxi/Kconfig of Linux.

So either: CONFIG_ARCH_SUNXI + CONFIG_TARGET_SUN[45678]I
Or: CONFIG_ARCH_SUNXI + CONFIG_MACH_SUN[45679]I?

I'm not too fussed but I think the second sounds good and leaves
CONFIG_TARGET_* available for the individual boards if we end up
wanting/needing that. Sound good to everyone?

Ian.

  reply	other threads:[~2014-10-24 13:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-04  8:47 [U-Boot] [PATCH for-next 0/3] sunxi: Kconfig consolidation and cleanup Ian Campbell
2014-10-04  8:48 ` [U-Boot] [PATCH for-next 1/3] sunxi: Kconfig: Consolidate SYS_CONFIG_NAME settings Ian Campbell
2014-10-06  7:48   ` Hans de Goede
2014-10-06  8:23     ` Ian Campbell
2014-10-04  8:48 ` [U-Boot] [PATCH for-next 2/3] sunxi: kconfig: Add top-level TARGET_SUNXI Ian Campbell
2014-10-05  2:37   ` Chen-Yu Tsai
2014-10-06  1:39   ` Masahiro Yamada
2014-10-06  8:27     ` Ian Campbell
2014-10-06 10:54       ` Masahiro Yamada
2014-10-22 19:14         ` Ian Campbell
2014-10-24 11:46           ` Masahiro Yamada
2014-10-24 13:22             ` Ian Campbell [this message]
2014-10-24 14:04               ` Hans de Goede
2014-10-26 16:55               ` Masahiro YAMADA
2014-10-06  7:55   ` Hans de Goede
2014-10-04  8:48 ` [U-Boot] [PATCH for-next 3/3] sunxi: Kconfig: Make SPL_FEL a toplevel Kconfig option Ian Campbell
2014-10-06  7:58   ` Hans de Goede
2014-10-06  8:28     ` Ian Campbell
2014-10-06  8:43       ` Hans de Goede
2014-10-04  9:32 ` [U-Boot] [PATCH for-next 0/3] sunxi: Kconfig consolidation and cleanup Ian Campbell
2014-10-06  2:16   ` Masahiro Yamada
2014-10-06  8:22     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414156950.15687.44.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox