u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/7] sunxi: Kconfig consolidation and cleanup
Date: Fri, 24 Oct 2014 21:20:10 +0100	[thread overview]
Message-ID: <1414182010.3584.9.camel@hellion.org.uk> (raw)

This series consolidates some Kconfig options and makes SPL_FEL a first
class .config member instead of putting it in CONFIG_SYS_EXTRA_OPTIONS.

This means it is possible to do a FEL build for any board with:
        make <board>_config
        echo CONFIG_SPL_FEL=y >> .config
        echo CONFIG_SPL_FEL=y >> spl/.config
or better
        make <board>_config
        sed -i -e 's/\# CONFIG_SPL_FEL is not set/CONFIG_SPL_FEL=y/g' .config spl/.config
which is still one more step than I would like but still preferable IMHO
to:
        sed -i -e 's/^CONFIG_SYS_EXTRA_OPTIONS="[^"]*/&,SPL_FEL/g' .config spl/.config

Near the end I've added a patch which adds <BOARD>_felconfig to automate
this, not sure how folks will feel about this, so I've deliberately made
it last so it can easily be ignored...

I've been using a little hack (below, updated to use felconfig) to
MAKEALL to help build test all this.

Since v1:
      * Rebased to current u-boot-sunxi#next
      * Hans' equivalent of my first patch has been applied to
        u-boot-sunxi#next, so my patch is dropped
      * Toplevel option is now CONFIG_ARCH_SUNXI
      * Per-SoC options are now CONFIG_MACH_SUN[45678]I
      * Board selection has been pulled out of CONFIG_SYS_EXTRA_OPTIONS
        into Kconfig, as CONFIG_TARGET_<BOARD>
      * The <BOARD>_FEL_defconfig files are now removed

Ian.

My MAKEALL hack, surely not upstreamable ;-)

diff --git a/MAKEALL b/MAKEALL
index 7c16319..3a8d1d0 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -660,6 +660,11 @@ build_target() {
        echo "Building ${target} board..."
        ${MAKE} -s ${target}_defconfig >/dev/null
 
+       if [ -n "$SUNXI_FORCE_FEL" ] ; then
+           sed -i -e 's/\# CONFIG_SPL_FEL is not set/CONFIG_SPL_FEL=y/g' \
+               .config spl/.config
+       fi
+
        ${MAKE} ${JOBS} ${CHECK} all \
                >${LOG_DIR}/$target.MAKELOG 2> ${LOG_DIR}/$target.ERR
 

             reply	other threads:[~2014-10-24 20:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 20:20 Ian Campbell [this message]
2014-10-24 20:20 ` [U-Boot] [PATCH v2 1/7] sunxi: kconfig: Add top-level ARCH_SUNXI Ian Campbell
2014-10-24 20:20 ` [U-Boot] [PATCH v2 2/7] sunxi: kconfig: Rename TARGET_SUN[45678]I to MACH_SUN[45678]I Ian Campbell
2014-10-24 20:20 ` [U-Boot] [PATCH v2 3/7] sunxi: Kconfig: Make SPL_FEL a toplevel Kconfig option Ian Campbell
2014-10-24 20:20 ` [U-Boot] [PATCH v2 4/7] sunxi: Use CONFIG_MACH_SUN?I from Kconfig instead of CONFIG_SUN?I Ian Campbell
2014-10-24 20:20 ` [U-Boot] [PATCH v2 5/7] sunxi: Drop FEL variants of defconfigs Ian Campbell
2014-10-24 20:20 ` [U-Boot] [PATCH v2 6/7] sunxi: kconfig: Introduce CONFIG_TARGET_<BOARD> Ian Campbell
2014-10-24 20:20 ` [U-Boot] [PATCH v2 7/7] sunxi: kconfig: Add %_felconfig rule to enable FEL build of sunxi platforms Ian Campbell
2014-10-27 11:08   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414182010.3584.9.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).