From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] e1000: fix sw fw sync on igb i210/i211
Date: Sun, 26 Oct 2014 22:57:56 +0100 [thread overview]
Message-ID: <1414360676.2322.32.camel@localhost.localdomain> (raw)
In-Reply-To: <CAJ+vNU3pQWKeJocm-HmnjVbgxMQPmCAvJJK9SBiteLU+rtD4OQ@mail.gmail.com>
On Thu, 2014-10-23 at 01:12 -0700, Tim Harvey wrote:
> I've never been able to get e1000_swfw_sync_acquire() to not timeout
> on the boards with i210 devices that I have (IMX6 with 2x i210
> programmed as 8086:1533 using int phys).
Ah, OK. I see. We do use them in flash less aka iNVM only mode as
8086:157b.
> In my case with your patch
> below as well as York's patch
> (https://patchwork.ozlabs.org/patch/400628/) I still see failures. The
> I210_SW_FW_SYNC reg returns swfw_sync=0x03, fwmask=0x20000, and
> swmask=0x2 which results in:
>
> Driver can't access resource, SW_FW_SYNC timeout.
> Unable to acquire swfw sync
> Error Resetting the PHY
> e1000: e1000#0: ERROR: Hardware Initialization Failed
As follows my results:
unprogrammed i210
01:00.0 - 8086:1531 - Network controller
swfw_sync=0x0, fwmask=0x20000, swmask=0x2
e1000: e1000#0: ERROR: Hardware Initialization Failed
programmed i210
01:00.0 - 8086:157b - Network controller
swfw_sync=0x0, fwmask=0x20000, swmask=0x2
working
unprogrammed i211
01:00.0 - 8086:1532 - Network controller
swfw_sync=0x0, fwmask=0x20000, swmask=0x2
working
programmed i211
01:00.0 - 8086:1539 - Network controller
swfw_sync=0x0, fwmask=0x20000, swmask=0x2
working
> I've always had to ignore the return value from e1000_reset() to avoid
> this issue and use the devices.
As mentioned before for me only the unprogrammed i210 gives me grief as
it does not assert the CFG_DONE bit in the EEMNGCTL register upon PHY
reset. However the e1000_swfw_sync_acquire() always works just fine.
> Any ideas?
Maybe the flash less aka iNVM only i210 behaves differently.
Let me enquire Intel about this as well, I anyway need to ask our rep
about the latest eepromARM programming tool as we have an upcoming
production lot of a few thousand units arrive any minute now.
> I don't have any i211's but I'll see if I can get hold of an
> unprogrammed i210 to test with.
Sure, would be interesting to see whether yours behave equally.
next prev parent reply other threads:[~2014-10-26 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bd71d1eb1cf3ba594ba7492f4f311fb1bf58dfd8.1413893734.git.marcel@ziswiler.com>
2014-10-21 12:26 ` [U-Boot] [PATCH] e1000: fix sw fw sync on igb i210/i211 Marcel Ziswiler
2014-10-23 8:12 ` Tim Harvey
2014-10-26 21:57 ` Marcel Ziswiler [this message]
2014-10-27 20:55 ` Tim Harvey
2014-10-27 22:21 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414360676.2322.32.camel@localhost.localdomain \
--to=marcel@ziswiler.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox