public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Paul Kocialkowski <contact@paulk.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] twl4030: TWL4030 VMMC2 3.2V enable on MMC init
Date: Tue, 28 Oct 2014 17:04:17 +0100	[thread overview]
Message-ID: <1414512257.2218.41.camel@aldrin> (raw)
In-Reply-To: <544FBA8B.7000200@compulab.co.il>

> Usually, it is a good practice to add a commit message
> (and not just the subject).
> 
> It will be highly appreciated if you can provide also an
> explanation (in the commit message) of what and why it is done.

Well, to be honest, I thought it was all self explanatory, but maybe a
bit more context is required. I didn't notice I wrote twl4030 twice, so
I'll probably make a v2, including a description.

Thanks!

> > ---
> >  drivers/power/twl4030.c |    6 ++++++
> >  include/twl4030.h       |    2 ++
> >  2 files changed, 8 insertions(+)
> > 
> > diff --git a/drivers/power/twl4030.c b/drivers/power/twl4030.c
> > index 3e50310..e578ae6 100644
> > --- a/drivers/power/twl4030.c
> > +++ b/drivers/power/twl4030.c
> > @@ -98,4 +98,10 @@ void twl4030_power_mmc_init(void)
> >  				TWL4030_PM_RECEIVER_VMMC1_VSEL_32,
> >  				TWL4030_PM_RECEIVER_VMMC1_DEV_GRP,
> >  				TWL4030_PM_RECEIVER_DEV_GRP_P1);
> > +
> > +	/* Set VMMC2 to 3.15 Volts */
> > +	twl4030_pmrecv_vsel_cfg(TWL4030_PM_RECEIVER_VMMC2_DEDICATED,
> > +				TWL4030_PM_RECEIVER_VMMC2_VSEL_32,
> > +				TWL4030_PM_RECEIVER_VMMC2_DEV_GRP,
> > +				TWL4030_PM_RECEIVER_DEV_GRP_P1);
> >  }
> > diff --git a/include/twl4030.h b/include/twl4030.h
> > index 093c61d..18795a6 100644
> > --- a/include/twl4030.h
> > +++ b/include/twl4030.h
> > @@ -395,6 +395,8 @@
> >  #define TWL4030_PM_RECEIVER_VDAC_VSEL_18		0x03
> >  #define TWL4030_PM_RECEIVER_VMMC1_VSEL_30		0x02
> >  #define TWL4030_PM_RECEIVER_VMMC1_VSEL_32		0x03
> > +#define TWL4030_PM_RECEIVER_VMMC2_VSEL_30		0x0B
> > +#define TWL4030_PM_RECEIVER_VMMC2_VSEL_32		0x0C
> >  #define TWL4030_PM_RECEIVER_VSIM_VSEL_18		0x03
> >  
> >  /* Device Selection in PM Receiver Module */
> > 

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution

Website:        http://www.replicant.us/
Wiki/Tracker:   http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141028/3a00d9b9/attachment.pgp>

  reply	other threads:[~2014-10-28 16:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 14:05 [U-Boot] [PATCH] twl4030: TWL4030 VMMC2 3.2V enable on MMC init Paul Kocialkowski
2014-10-28 15:47 ` Igor Grinberg
2014-10-28 16:04   ` Paul Kocialkowski [this message]
2014-10-28 17:14 ` [U-Boot] [PATCH v2] twl4030: " Paul Kocialkowski
2014-10-30 15:22   ` Pantelis Antoniou
2014-10-30 23:35   ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414512257.2218.41.camel@aldrin \
    --to=contact@paulk.fr \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox