From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Wed, 29 Oct 2014 08:05:20 +0000 Subject: [U-Boot] [PATCH v2 6/6] dm: sunxi: Add support for serial using driver model In-Reply-To: References: <1414036962-28463-1-git-send-email-sjg@chromium.org> <1414036962-28463-7-git-send-email-sjg@chromium.org> <1414143754.15687.28.camel@hellion.org.uk> Message-ID: <1414569920.3584.33.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 2014-10-27 at 18:06 -0600, Simon Glass wrote: > Hi Ian, > > On 24 October 2014 03:42, Ian Campbell wrote: > > On Wed, 2014-10-22 at 22:02 -0600, Simon Glass wrote: > >> Add a driver for the designware serial UART used on sunxi. This just > >> redirects to the normal ns16550 driver. > >> > >> Add a stdout-path to the device tree so that the correct UART is chosen. > >> > >> Signed-off-by: Simon Glass > > > > Should the UART related code in > > arch/arm/cpu/armv7/sunxi/board.c:gpio_init() be nobbled in this > > configuration? > > Yes I think that needs attention. Ideally we should be able to have > this handled by the serial driver (requesting the pinmux it needs) but > we don't have infrastructure for that as yet. Ah, I thought your earlier GPIO patches were that, but I suppose not. > Suggestions? What does the kernel do here? It has pinmux infra. In the meantime could we somehow replace/augment the #ifdef chain in gpio_init with something keyed off the stdout alias perhaps? Ian.