From mboxrd@z Thu Jan  1 00:00:00 1970
From: Destrukto <simon.bielmann@gmx.ch>
Date: Tue, 4 Dec 2007 00:33:09 -0800 (PST)
Subject: [U-Boot-Users] AT91SAM9260-EK: Trying to load U-Boot env from
 NAND
In-Reply-To: <20071203095544.3AE6C2430C@gemini.denx.de>
References: <14022552.post@talk.nabble.com>
	<494375.44488.qm@web94810.mail.in2.yahoo.com>
	<14028021.post@talk.nabble.com>
	<978780.75419.qm@web94809.mail.in2.yahoo.com>
	<14124814.post@talk.nabble.com>
	<20071203095544.3AE6C2430C@gemini.denx.de>
Message-ID: <14146625.post@talk.nabble.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


Well, until now I haven't got any problem with this solution. So until I
can't find any better solution I will use the system as long as it works.

wd wrote:
> 
> In message <14124814.post@talk.nabble.com> you wrote:
>> 
>> Yes! I get it work, the problem was, that it had a problem to accept the
>> crc32-Checksum. So I just erased the sequence where this happens. Here
>> the
>> patchfile:
>> 
>> --- env_nand.c	2007-11-30 14:15:03.000000000 +0100
>> +++ env_nand.c	2007-11-30 14:16:17.000000000 +0100
>> @@ -247,13 +247,7 @@ void env_relocate_spec (void)
>>  		crc2_ok = (crc32(0, tmp_env2->data, ENV_SIZE) == tmp_env2->crc);
>>  	}
>>  
>> -	if(!crc1_ok && !crc2_ok)
>> -		return use_default();
>> -	else if(crc1_ok && !crc2_ok)
>> -		gd->env_valid = 1;
>> -	else if(!crc1_ok && crc2_ok)
>> -		gd->env_valid = 2;
>> -	else {
>> +	
>>  		/* both ok - check serial */
> 
> You mean you completely castrated all logic that would verify if the
> environment is OK? Arrggghhhh...
> 
>> Maybe it isn't the best solution but it works ;)
> 
> You THINK it works, but actually it's completely broken.
> 
> Don't do that!!!
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "UNIX was not designed to stop you from doing stupid things,  because
> that would also stop you from doing clever things."       - Doug Gwyn
> 
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
> 
> 

-- 
View this message in context: http://www.nabble.com/AT91SAM9260-EK%3A-Trying-to-load-U-Boot-env-from-NAND-tf4896117.html#a14146625
Sent from the Uboot - Users mailing list archive at Nabble.com.