From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Sat, 08 Nov 2014 10:19:16 +0000 Subject: [U-Boot] [PATCH v3 02/11] sun6i: Add basic axp221 driver In-Reply-To: <1415389629-1298-3-git-send-email-hdegoede@redhat.com> References: <1415389629-1298-1-git-send-email-hdegoede@redhat.com> <1415389629-1298-3-git-send-email-hdegoede@redhat.com> Message-ID: <1415441956.2030.9.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 2014-11-07 at 20:47 +0100, Hans de Goede wrote: > From: Oliver Schinagl > > The A31 uses the AXP221 pmic for various voltages. > > Signed-off-by: Oliver Schinagl > Signed-off-by: Hans de Goede > + cfg |= 1 << 7; > + cfg |= 1 << 3; > + cfg |= 1 << 4; > + cfg |= 1 << 5; > + cfg |= 1 << 6; > + cfg |= 1 << 6; > + cfg |= 1 << 7; > + cfg |= 1 << 7; Could we get some symbolic names for these please? Looks like a helper to read/modify/write a p2wi register would reduce the repetition a fair bit. Ian.