public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] spl: Change debug to printf for "Unsupported boot-device"
Date: Tue, 11 Nov 2014 19:03:55 +0100	[thread overview]
Message-ID: <1415729035-9765-1-git-send-email-sr@denx.de> (raw)

We had the problem on an AM33xx platform, that SPL detected an
unsupported boot-device. But since this message is a debug message
it took a bit of time to really know, where the hangup in SPL
resulted from. So let's change this debug message to a printf
and also print the detected boot-device that is not supported.
This makes debugging of such cases much easier.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Tom Rini <trini@ti.com>
---
v2:
- Added #if check so that the printf is only included when serial support
  is enabled.
- Compile tested on all ARM boards

 common/spl/spl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index d85bab3..cef7bca 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -216,7 +216,9 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
 		break;
 #endif
 	default:
-		debug("SPL: Un-supported Boot Device\n");
+#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
+		printf("SPL: Unsupported Boot Device %d\n", boot_device);
+#endif
 		hang();
 	}
 
-- 
2.1.3

             reply	other threads:[~2014-11-11 18:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 18:03 Stefan Roese [this message]
2014-11-13  6:52 ` [U-Boot] [PATCH v2] spl: Change debug to printf for "Unsupported boot-device" Heiko Schocher
2014-11-24 22:10 ` [U-Boot] [U-Boot, " Tom Rini
2015-01-27 13:43   ` Michal Simek
2015-01-27 14:08     ` Stefan Roese
2015-01-27 14:22     ` Tom Rini
2015-01-27 14:38       ` Stefan Roese
2015-01-27 14:40         ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415729035-9765-1-git-send-email-sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox