public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mtd: nand: omap_gpmc: Add CONFIG_SYS_NAND_USE_READY to enable ready/busy
Date: Wed, 12 Nov 2014 14:54:33 -0600	[thread overview]
Message-ID: <1415825673.15957.41.camel@freescale.com> (raw)
In-Reply-To: <1415789592-5192-1-git-send-email-sr@denx.de>

On Wed, 2014-11-12 at 11:53 +0100, Stefan Roese wrote:
> By defining CONFIG_SYS_NAND_USE_READY the GPMC NAND driver makes
> use of the ready pin / signal for busy / ready detection. This function
> is already available but currently only used in SPL. I don't see a reason
> to not use it in the main U-Boot as well. As it increases the NAND
> performance.
> 
> I'm making it configurable, so that boards that might now have this pin
> connected are still supported.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Roger Meier <r.meier@siemens.com>
> Cc: Samuel Egli <samuel.egli@siemens.com>
> ---
>  README                       |  5 +++++
>  drivers/mtd/nand/omap_gpmc.c | 20 +++++++++++++++++---
>  2 files changed, 22 insertions(+), 3 deletions(-)
> 
> diff --git a/README b/README
> index c3a9dfc..420c14b 100644
> --- a/README
> +++ b/README
> @@ -4731,6 +4731,11 @@ Low Level (hardware related) configuration options:
>  		- drivers/mtd/nand/ndfc.c
>  		- drivers/mtd/nand/mxc_nand.c
>  
> +- CONFIG_SYS_NAND_USE_READY
> +		Defined if a ready/busy pin is available on this board
> +		which can be used to determine the state of the NAND
> +		chip. Currently used on the OMAP/AM33xx NAND driver.
> +

New symbols should be done in kconfig.

Is this really something that ought to be a generic symbol, rather than
OMAP-specific?

-Scott

  parent reply	other threads:[~2014-11-12 20:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 10:53 [U-Boot] [PATCH 1/2] mtd: nand: omap_gpmc: Add CONFIG_SYS_NAND_USE_READY to enable ready/busy Stefan Roese
2014-11-12 10:53 ` [U-Boot] [PATCH 2/2] arm: am335x: Enable CONFIG_SYS_NAND_USE_READY on siemens am33xx Stefan Roese
2014-11-12 20:54 ` Scott Wood [this message]
2014-11-12 21:34 ` [U-Boot] [PATCH 1/2] mtd: nand: omap_gpmc: Add CONFIG_SYS_NAND_USE_READY to enable ready/busy Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415825673.15957.41.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox