From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc@hellion.org.uk>
Date: Sun, 16 Nov 2014 11:35:51 +0000
Subject: [U-Boot] [PATCH 3/6] sunxi: video: Add cfb console driver for
	sunxi
In-Reply-To: <1415984088-6800-4-git-send-email-hdegoede@redhat.com>
References: <1415984088-6800-1-git-send-email-hdegoede@redhat.com>
	<1415984088-6800-4-git-send-email-hdegoede@redhat.com>
Message-ID: <1416137751.25454.8.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, 2014-11-14 at 17:54 +0100, Hans de Goede wrote:
> +/* this is needed so the above will actually do something */
> +#define CONFIG_SYS_CONSOLE_IS_IN_ENV
> [...] 
> +#ifdef CONFIG_VIDEO
> +#define CONSOLE_ENV_SETTINGS \
> +	"stdin=serial\0" \
> +	"stdout=serial,vga\0" \
> +	"stderr=serial,vga\0"
> +#else
> +#define CONSOLE_ENV_SETTINGS

Now that CONFIG_SYS_CONSOLE_IS_IN_ENV is set do we need to either say
something here and/or provide the overwrite_console() hook?

Perhaps something along the lines of:
        #ifdef CONFIG_VIDEO
        #define CONSOLE_ENV_VGA_SETTINGS ",vga"
        #endif
        
        #define CONSOLE_ENV_SETTINGS \
        	"stdin=serial\0" \
        	"stdout=serial" CONSOLE_ENV_VGA_SETTINGS "\0" \
        	"stderr=serial" CONSOLE_ENV_VGA_SETTINGS "\0"
         
Has this been tested on a serial-only board?

Ian.